Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Apr 2021 07:47:31 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 2d8adf9cc000 - stable/12 - ixgbe: Clarify index name in ixgbe_mc_filter_apply
Message-ID:  <202104250747.13P7lVPQ055834@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kbowling (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=2d8adf9cc0000d29d330d2ce06f659b207c0d11b

commit 2d8adf9cc0000d29d330d2ce06f659b207c0d11b
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2021-04-17 01:17:43 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-04-25 07:47:06 +0000

    ixgbe: Clarify index name in ixgbe_mc_filter_apply
    
    "It looks like it would be less confusing to rename 'count' to
    something like 'idx', since that's what it's used for in this
    function."
    
    Reviewed by:    erj
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D29798
    
    (cherry picked from commit 21afed4b1d18578aa8c9fa31e9e677971f8b4300)
---
 sys/dev/ixgbe/if_ix.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
index 80f812336d2c..b987369aefde 100644
--- a/sys/dev/ixgbe/if_ix.c
+++ b/sys/dev/ixgbe/if_ix.c
@@ -3239,18 +3239,18 @@ ixgbe_config_delay_values(struct adapter *adapter)
  *   Called whenever multicast address list is updated.
  ************************************************************************/
 static int
-ixgbe_mc_filter_apply(void *arg, struct ifmultiaddr *ifma, int count)
+ixgbe_mc_filter_apply(void *arg, struct ifmultiaddr *ifma, int idx)
 {
 	struct adapter *adapter = arg;
 	struct ixgbe_mc_addr *mta = adapter->mta;
 
 	if (ifma->ifma_addr->sa_family != AF_LINK)
 		return (0);
-	if (count == MAX_NUM_MULTICAST_ADDRESSES)
+	if (idx == MAX_NUM_MULTICAST_ADDRESSES)
 		return (0);
 	bcopy(LLADDR((struct sockaddr_dl *)ifma->ifma_addr),
-	    mta[count].addr, IXGBE_ETH_LENGTH_OF_ADDRESS);
-	mta[count].vmdq = adapter->pool;
+	    mta[idx].addr, IXGBE_ETH_LENGTH_OF_ADDRESS);
+	mta[idx].vmdq = adapter->pool;
 
 	return (1);
 } /* ixgbe_mc_filter_apply */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104250747.13P7lVPQ055834>