Date: Fri, 4 Feb 2022 15:06:57 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Renato Botelho <garga@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 66c5fbca7719 - main - insmntque1(): remove useless arguments Message-ID: <Yf0k8YgCP7w05BKy@kib.kiev.ua> In-Reply-To: <960b1d7d-d6ea-3379-cd64-df14993bf361@FreeBSD.org> References: <202201311453.20VErBDO081800@gitrepo.freebsd.org> <960b1d7d-d6ea-3379-cd64-df14993bf361@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 04, 2022 at 10:02:05AM -0300, Renato Botelho wrote: > On 31/01/22 11:53, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=66c5fbca7719dca1ac361a010fa511a4514a662d > > > > commit 66c5fbca7719dca1ac361a010fa511a4514a662d > > Author: Konstantin Belousov <kib@FreeBSD.org> > > AuthorDate: 2022-01-28 00:57:09 +0000 > > Commit: Konstantin Belousov <kib@FreeBSD.org> > > CommitDate: 2022-01-31 14:49:08 +0000 > > > > insmntque1(): remove useless arguments > > Also remove once-used functions to clean up after failed insmntque1(), > > which were destructor callbacks in previous life. > > Reviewed by: markj > > Tested by: pho > > Sponsored by: The FreeBSD Foundation > > Differential revision: https://reviews.freebsd.org/D34071 > > This change broke emulators/open-vm-tools [1]. Can you give me some advice > to fix it? > > [1] https://github.com/vmware/open-vm-tools/blob/42ce53f39be45b7795a9f1adf892af84629b4a19/open-vm-tools/modules/freebsd/vmblock/subr.c#L396 > error = insmntque1(vp, mp); if (error != 0) { VMBlockInsMntQueDtr(vp, xp); return error; } It was broken before already, but in subtle way, the destructor was not called.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yf0k8YgCP7w05BKy>