Date: Tue, 13 Sep 2011 11:46:12 +0200 From: Andreas Longwitz <longwitz@incore.de> To: Adrian Chadd <adrian@freebsd.org>, freebsd-stable@freebsd.org Subject: Re: UFS_DIRHASH panics on a dozen server within 30 hours Message-ID: <4E6F2664.6000703@incore.de> In-Reply-To: <CAJ-Vmon4XBQ4vvJOVGSiOdgX1W78x8EUmcVqtMgFPJgnP-FfFw@mail.gmail.com> References: <4E64933E.8030908@incore.de> <201109061104.43409.jhb@freebsd.org> <4E6D34FE.70703@incore.de> <CAJ-Vmon4XBQ4vvJOVGSiOdgX1W78x8EUmcVqtMgFPJgnP-FfFw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, > You're doing a 25k allocation (why not just go with an even 32k?) but > you're not enforcing anywhere that if au_length > your #defined value, > the malloc size is made larger. > I know it's a nitpick, but if it were me doing a change, I'd use > MAX(au_length, MAX_AMR_IOCTL) when doing the malloc. Thank you for this hint, I have posted this to kern/155658. -- Dr. Andreas Longwitz Data Service GmbH Beethovenstr. 2A 23617 Stockelsdorf Amtsgericht Lübeck, HRB 318 BS Geschäftsführer: Wilfried Paepcke, Dr. Andreas Longwitz, Josef Flatau
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E6F2664.6000703>