Date: Wed, 18 May 2016 16:14:25 -0600 From: Ian Lepore <ian@freebsd.org> To: Gleb Smirnoff <glebius@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300167 - in head: contrib/bsnmp/snmpd usr.sbin/bsnmpd/bsnmpd Message-ID: <1463609665.1180.301.camel@freebsd.org> In-Reply-To: <201605182202.u4IM2JF7047307@repo.freebsd.org> References: <201605182202.u4IM2JF7047307@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2016-05-18 at 22:02 +0000, Gleb Smirnoff wrote: > Author: glebius > Date: Wed May 18 22:02:19 2016 > New Revision: 300167 > URL: https://svnweb.freebsd.org/changeset/base/300167 > > Log: > Revert r299830, it has couple of fatal errors. > > The CMSG_ family of macros take care of alignment, so we don't need > r299830 > at all, even if it was correct. Put NO_WCAST_ALIGN into Makefile. > So all of this was about a "cast increases required alignment" kind of warning for a macro that takes care of alignment? Wouldn't the proper fix then be to change CMSG_DATA() so that its internal cast is void* instead of unsigned char* (he asked, knowing Bruce would come along soon and point out why that's a dumb question)? -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1463609665.1180.301.camel>