Date: Sat, 19 Oct 2024 10:31:12 -0400 From: Mark Johnston <markj@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4f2ca36c7bec - main - arm64: Disable coverage sanitization of `pmap_update_strided` Message-ID: <ZxPCsF7t_m2T1vWu@nuc> In-Reply-To: <92030090-11B4-484B-8FD4-6B92F34FD717@freebsd.org> References: <202410111653.49BGrin3091045@gitrepo.freebsd.org> <92030090-11B4-484B-8FD4-6B92F34FD717@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 18, 2024 at 10:01:18PM +0100, Jessica Clarke wrote: > On 11 Oct 2024, at 17:53, Mark Johnston <markj@FreeBSD.org> wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4f2ca36c7becd20b21ce5ef7256bbd42f732dafe > > > > commit 4f2ca36c7becd20b21ce5ef7256bbd42f732dafe > > Author: Zhuo Ying Jiang Li <zhuoyingjiangli@gmail.com> > > AuthorDate: 2024-10-11 16:41:49 +0000 > > Commit: Mark Johnston <markj@FreeBSD.org> > > CommitDate: 2024-10-11 16:52:53 +0000 > > > > arm64: Disable coverage sanitization of `pmap_update_strided` > > > > The break-before-make update invalidates PTEs, including the PTE > > pointing to curthread, causing a fault in `trace_pc`. This > > addresses a similar issue in > > 01bb9a2a3557bc9389f628d301cd691e08266f1d. > > This broke* GitHub Actions due to the use of Clang 12 (newest Clang in > Ubuntu 20.04 LTS which isn’t EOL until April 2025) which doesn’t > support this sanitiser. Probably the easiest thing to do is to leave > the relevant __nosanitizefoo defined to nothing unless that sanitiser > is actually enabled (via __has_feature), as it’s not necessary outside > of that, and if it’s enabled then you know it’s supported? This seems to work, in that I reproduced the build failure locally with CROSS_TOOLCHAIN=llvm12 and then verified this patch: https://reviews.freebsd.org/D47193 > Jess > > * Masked by the OpenZFS import breaking it earlier in both commit > history and build order >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZxPCsF7t_m2T1vWu>