Date: Wed, 8 Mar 2017 13:57:32 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Andriy Gapon <avg@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe Message-ID: <B73C6E5C-75EA-4871-AAEC-FFA5049C5344@gmail.com> In-Reply-To: <20170308215514.GQ1044@FreeBSD.org> References: <201703071543.v27FhnoL024242@repo.freebsd.org> <20170307221733.GN1044@FreeBSD.org> <70fcdcf4-cfa5-2382-ea60-55ac1a91e06b@FreeBSD.org> <20170308215514.GQ1044@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_139152D0-5504-4E01-B805-BE1501A90845 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 8, 2017, at 13:55, Gleb Smirnoff <glebius@FreeBSD.org> wrote: >=20 > On Wed, Mar 08, 2017 at 01:00:30AM +0200, Andriy Gapon wrote: > A> On 08/03/2017 00:17, Gleb Smirnoff wrote: > A> > On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: > A> > A> Author: avg > A> > A> Date: Tue Mar 7 15:43:49 2017 > A> > A> New Revision: 314862 > A> > A> URL: https://svnweb.freebsd.org/changeset/base/314862 > A> > A> > A> > A> Log: > A> > A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC = happy > A> > A> > A> > A> The module uses unnamed structure and union fields and base = GCC in > A> > A> stable/10 doesn't like it. > A> > A> I think that that is a C11 feature, so it is courteous of = more modern > A> > A> compilers to not complain about it when compiling in C99 = mode. > A> > > A> > There are a lot of code in kernel, that uses anonymous structs = and unions. > A> > This feature is enabled globally. Why does this module need = special treatment? > A> > A> That's a good question and I don't have a good answer to it. > A> All I can say is that a GCC build of GENERIC and modules failed in = that fashion > A> only for this module (in stable/10). > A> Maybe I described the problem incorrectly. Then, a proper = explanation is welcome. >=20 > In head this is fixed properly: >=20 > https://svnweb.freebsd.org/base?view=3Drevision&revision=3D278913 >=20 > Can you please move your fix to stable/10 and revert it in head? I understand there might be conflicts, but wouldn=E2=80=99t it be better = to revert and MFC the change you committed to ^/head (which is already = in ^/stable/11) to ^/stable/10? Thanks, -Ngie --Apple-Mail=_139152D0-5504-4E01-B805-BE1501A90845 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYwH5MAAoJEPWDqSZpMIYVlNcQAIetsCUhiDb5d1thCN3adUOq XGpgPDxLLkXVVthmcGcJFowvUya0wzDLExxa2AzhXxXQmgDbwHHuglLStEBuOQkd C0FvVcF+aFydMoVuWQGZLGak+2bD9zTNh1wddr46CDSDLW4zS7kj+LUF5N+pHck1 VIL28UBD0T0NvKm11B1B6sD0DOpdM8+b8TONiNrzPwbCur0EEXpOB2CEfhVbcgTH 2SVO0lqLxkiYSJQuImWwwAKAR7M0rJZY3psbEYGJ4L/27gzm0U1GUgPxfIwkRdv3 KSWH+zFdbY9dLAoSLnnGq7evAfsfpwOFNlEjcN68nnE7g08WUIdOWsZxQxnXopas uBvqRpdXmFh0n46iY0iZQVTJKRkx8d/H1QSI0yLbujI+Mn4cqI0Twf0O9NfPw2Z0 ur3o3EqXXbC/5uzYLEOHQxhVHLgxE1BT7mv5mGtau8teTSs7G4F0L0X5qYjTYb8S eU0iwOKA6Oq00vdMTM5LbhwsbLwSBvOrquxsuNTi71QNfo41xaEG50t8WhIHU53H jUKBvCubRdaSU1IH/KScbEKW5gSxzFDacd06qa0u+UPsUUhXNf0d2b/fSfpEPDnX P4vPd4Fgq4hYUYcXlqRJIpsCXAPFegorYI+pCktwS+6e7ud/x1/wZ/RhKDRI4ln8 ZCM7xxPDHKU0d846DEVI =EkqE -----END PGP SIGNATURE----- --Apple-Mail=_139152D0-5504-4E01-B805-BE1501A90845--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B73C6E5C-75EA-4871-AAEC-FFA5049C5344>