Date: Sun, 28 Dec 2014 16:57:33 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 186891] [puc] [patch] MCS9922 based card not known Message-ID: <bug-186891-8-lTBjeQARW5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-186891-8@https.bugs.freebsd.org/bugzilla/> References: <bug-186891-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186891 greg@codeconcepts.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |greg@codeconcepts.com --- Comment #4 from greg@codeconcepts.com --- The suggested patch seems to work for me. Card is "SYBA PCI-Express 2 Port Serial Card" (16C450/16C550 UART, with 256-byte FIFO in tx/rx for each port= .=20 Based on PR 171746, I suspect the rx FIFO is being dumbed down to 16-bytes = by ns8250_bus_probe(). FreeBSD harper 10.1-STABLE FreeBSD 10.1-STABLE #2 r276320M: Sun Dec 28 08:0= 3:01 CST 2014 root@harper:/usr/obj/usr/src/sys/HARPER amd64 $ svn diff sys/dev/uart Index: sys/dev/uart/uart_bus_pci.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/uart/uart_bus_pci.c (revision 276320) +++ sys/dev/uart/uart_bus_pci.c (working copy) @@ -136,6 +136,8 @@ "MosChip MCS9901 PCIe to Peripheral Controller", 0x10 }, { 0x9710, 0x9904, 0xa000, 0x1000, "MosChip MCS9904 PCIe to Peripheral Controller", 0x10 }, +{ 0x9710, 0x9922, 0xa000, 0x1000, + "MosChip MCS9922 PCIe to Peripheral Controller", 0x10 }, { 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0x10 = }, { 0xffff, 0, 0xffff, 0, NULL, 0, 0} }; pciconf -lv output: uart2@pci0:10:0:0: class=3D0x070002 card=3D0x1000a000 chip=3D0x99229710 re= v=3D0x00 hdr=3D0x00 vendor =3D 'NetMos Technology' device =3D 'PCIe 9922 Multi-I/O Controller' class =3D simple comms subclass =3D UART uart3@pci0:10:0:1: class=3D0x070002 card=3D0x1000a000 chip=3D0x99229710 re= v=3D0x00 hdr=3D0x00 vendor =3D 'NetMos Technology' device =3D 'PCIe 9922 Multi-I/O Controller' class =3D simple comms subclass =3D UART (In reply to Marius Strobl from comment #2) > On Thu, Apr 10, 2014 at 11:26:56PM +0200, Marius Strobl wrote: > > Could you please revert your > > patch for puc(4) and test whether the attached one provies you with > > two instances of uart(4) for that card? > >=20 > > Index: uart_bus_pci.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- uart_bus_pci.c (revision 264257) > > +++ uart_bus_pci.c (working copy) > > @@ -135,6 +135,8 @@ > > "MosChip MCS9901 PCIe to Peripheral Controller", 0x10 }, > > { 0x9710, 0x9904, 0xa000, 0x1000, > > "MosChip MCS9904 PCIe to Peripheral Controller", 0x10 }, > > +{ 0x9710, 0x9922, 0x0000, 0x0000, > > + "MosChip MCS9922 PCIe to Peripheral Controller", 0x10 }, > > { 0xdeaf, 0x9051, 0xffff, 0, "Middle Digital PC Weasel Serial Port", 0= x10 }, > > { 0xffff, 0, 0xffff, 0, NULL, 0, 0} > > }; >=20 > I'm not sure whether the sub vendor and sub device IDs taken from NetBSD > actually are correct. The MCS9922 datasheet suggests that the following > should be used instead: > +{ 0x9710, 0x9922, 0xa000, 0x1000, > + "MosChip MCS9922 PCIe to Peripheral Controller", 0x10 }, >=20 > Marius --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-186891-8-lTBjeQARW5>