Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jul 2003 22:02:50 +0200
From:      Thierry Thomas <thierry@pompo.net>
To:        FreeBSD-ports <ports@freebsd.org>
Cc:        Mathieu Arnold <mat@mat.cc>
Subject:   Libtoolize: where? Is it possible to rewrite configure-message?
Message-ID:  <20030728200250.GC3905@graf.pompo.net>

next in thread | raw e-mail | index | archive | help
Hello,

I have a problem with the port www/tidy-lib (slave port of
www/tidy-devel with defined WITH_SHLIB).

It required the sequence libtoolize & aclocal, and in the current port,
USE_AUTOMAKE_VER=15 is defined, and it is executed during post-patch:

post-patch:
.if !defined(WITH_SHLIB)
	@${CP} ${WRKSRC}/build/gmake/Makefile ${WRKSRC}
.else
	@${CP} -R -f ${WRKSRC}/build/gnuauto/* ${WRKSRC}
	(cd ${WRKSRC}	\
	&& ${LIBTOOLIZE} --force --copy	\
	&& ${ACLOCAL})
.endif

It kind-of-works, and even builds on Bento, but this is not
bullet-proof: Mathieu Arnold has reported a problem on a machine without
automake / aclocal. USE_AUTOMAKE produces a build-depends for
devel/automake, but the depends are brough in after post-patch, and it
aborts because aclocal is not found.

If I split this target and move (libtoolize & aclocal) to pre-configure,
this is too late: it must be somewhere between build-depends and
patch-libtool.

The /right way/ would be too introduce a new target do-libtoolize in
bsd.port.mk, but libtoolize is not used by a lot of ports.

The following patch works, but I don't know if it is legitimate to
rewrite configure-message?

--- tidy-devel.diff begins here ---
--- www/tidy-devel/Makefile.orig	Fri Jul 25 21:26:03 2003
+++ www/tidy-devel/Makefile	Sat Jul 26 23:01:12 2003
@@ -55,9 +55,14 @@
 	@${CP} ${WRKSRC}/build/gmake/Makefile ${WRKSRC}
 .else
 	@${CP} -R -f ${WRKSRC}/build/gnuauto/* ${WRKSRC}
+.endif
+
+configure-message:
+.if defined(WITH_SHLIB)
 	(cd ${WRKSRC}	\
 	&& ${LIBTOOLIZE} --force --copy	\
 	&& ${ACLOCAL})
+	@${ECHO_MSG} "===>  Configuring for ${PKGNAME}"
 .endif
 
 pre-install:
--- tidy-devel.diff ends here ---

Comments and better ideas are welcome!
-- 
Th. Thomas.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030728200250.GC3905>