Date: Wed, 16 Jul 2014 15:19:00 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r268750 - head/usr.bin/timeout Message-ID: <20140716121900.GX93733@kib.kiev.ua> In-Reply-To: <201407161141.s6GBfSbS034790@svn.freebsd.org> References: <201407161141.s6GBfSbS034790@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--U6vonYU9PXaZy4LQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 16, 2014 at 11:41:28AM +0000, Baptiste Daroussin wrote: > Author: bapt > Date: Wed Jul 16 11:41:28 2014 > New Revision: 268750 > URL: http://svnweb.freebsd.org/changeset/base/268750 >=20 > Log: > Sort headers > Constify long options > Remove useless call to sigemptyset > properly check errno when waiting for a process status when a SIGCHLD i= s received >=20 > Modified: > head/usr.bin/timeout/timeout.c >=20 > Modified: head/usr.bin/timeout/timeout.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/timeout/timeout.c Wed Jul 16 11:30:04 2014 (r268749) > +++ head/usr.bin/timeout/timeout.c Wed Jul 16 11:41:28 2014 (r268750) > @@ -28,20 +28,18 @@ > #include <sys/cdefs.h> > __FBSDID("$FreeBSD$"); > =20 > -#include <sys/types.h> > -#include <sys/time.h> > -#include <sys/wait.h> > +#include <err.h> > +#include <errno.h> > +#include <getopt.h> > #include <signal.h> > +#include <stdbool.h> > #include <stdio.h> > #include <stdlib.h> > #include <string.h> > +#include <sys/time.h> > +#include <sys/wait.h> > #include <sysexits.h> > #include <unistd.h> > -#include <getopt.h> > -#include <err.h> > -#include <spawn.h> > -#include <errno.h> > -#include <stdbool.h> This is not proper sorting. sys/*.h comes first, usermode headers second. > =20 > #define EXIT_TIMEOUT 124 > =20 > @@ -188,7 +186,7 @@ main(int argc, char **argv) > cpid =3D -1; > pgid =3D -1; > =20 > - struct option longopts[] =3D { > + const struct option longopts[] =3D { I noted that this should be static const, not just const. The curious tendency of late is people committing changes without getting final confirmation from reviewer. Asking to look at the patch before commit would avoid repo churn. --U6vonYU9PXaZy4LQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTxm2zAAoJEJDCuSvBvK1BAGkP/2wIJZC6QG3Qyg2ALrqgpas3 pekqgo/OmHc2bubBpjpbBfoL193O0VugmZTpJUeq8/F3IcUEqx3xUNz60XNI5K+R mSzZi2lp8J4M7czV56kMbzRxAaAbjHxDBePsRifYgWxsIG0IQc/K9Z2cmj6OTLXc Me+jq6OysJ6II0/mAmZTp8JQ0QcejlSip5VgK9domVzarQXk9b0214a0rK8djtOl IJltLPaCdPRsb69yRJsx3XL0j6J05OYwoXFSD3O4rqSb2zZq+OoojJAm3agA1F7n exxd/EHrQEZNgLG8lVASKbJivOeAVjMJ/S6PNcuOq+8jcCFMY8XbIuL3bNY7O9yd 8++MxlfrPPIJyoBCxWjAGS9X43V2IMVTF5fUQlrlk/eDwxnhFsc2RMUzoDmwJp8e TwOXYPRr3Nxcnb1a7cHyxMWTke3oMQbIghstGcTF5b6H+F1++Q3wnOcYDpIWIRMy vV3lib3LuHJsFHWuBV69VwkmXcSPTObF8HvmpM6EmODeeZFyP1hHvZYvI2GiEYqT HsuLjJJEqyogE/WvmcOtNJVYFIpOFJ0pK8ADAJb6bX6lBkFvegNnrZ9EAQDCdHK8 jETpBO6HwkRPlLwutkXB2/gxdhqzLzvEDK6+SwiualsVzRI6ka+ElVcgR4k6ByNC luweILmnUBEJVX20G2nh =oMM6 -----END PGP SIGNATURE----- --U6vonYU9PXaZy4LQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140716121900.GX93733>