Date: Mon, 15 May 1995 09:28:56 +0300 (EET DST) From: Kai Vorma <vode@freud.hut.fi> To: Nate Williams <nate@trout.sri.MT.net> Cc: "Andrey A. Chernov" <ache@freefall.cdrom.com>, CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c Message-ID: <Pine.HPP.3.91.950515090939.6388B-100000@freud.hut.fi> In-Reply-To: <199505150016.SAA24242@trout.sri.MT.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 14 May 1995, Nate Williams wrote: > Andrey A. Chernov writes: > > ache 95/05/14 17:03:33 > > > > Modified: usr.bin/rpcgen rpc_parse.c > > Log: > > End of listcan be not marked, fix it > > Submitted by: Kai Vorma <vode@snakemail.hut.fi> > > I looked at this fix, and I'm not sure that the proposed 'fix' was > necessary. Did you look at the fix at determine if it was indeed needed? Without this fix the last plist->next link is uninitialized. rpcgen still works, because the way BSD malloc works (it cannot reuse freed memory so it asks more from the system and that memory is zeroed -> next-link happens to be NULL). I have replaced the system malloc with a better one and rpcgen dumps core without this patch. ..vode
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.HPP.3.91.950515090939.6388B-100000>