Date: Sun, 24 Jul 2005 17:23:21 -0700 From: Nate Lawson <nate@root.org> To: Takanori Watanabe <takawata@init-main.com> Cc: freebsd-acpi@freebsd.org Subject: Re: acpi battery rework patch Message-ID: <42E430F9.3020009@root.org> In-Reply-To: <200507240618.j6O6ISWx093600@sana.init-main.com> References: <200507240618.j6O6ISWx093600@sana.init-main.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Takanori Watanabe wrote: > In message <42E29CAA.1020007@root.org>, Nate Lawson さんいわく: >>Sorry, the problem was I left a file out of the diff. I just committed >>the patch so please just cvsup and test from 7-CURRENT. > > I don't tried yet, but devclass battery should be shared between > any kind of batteries in your way. So move acpi_cmbat_devclass into > acpi_battery.c and change its name to acpi_battery_devclass. Yes, that is how the patch already works. As dfr@ told me, devclasses are matched based on name (i.e. "battery"), not by actual storage for the devclass_t. So there is no need to share anything but just reuse the same class string. Perhaps he can correct me if I'm wrong. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42E430F9.3020009>