Date: Wed, 8 Dec 2004 23:11:22 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Max Laier <max@love2party.net> Cc: net@freebsd.org Subject: Re: Another bug with netmasked aliases (with fix) Message-ID: <20041208211121.GB61146@ip.net.ua> In-Reply-To: <200412082107.05872.max@love2party.net> References: <20041207145932.GA1336@ip.net.ua> <200412082107.05872.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--ZfOjI3PrQbgiZnxM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Max,
On Wed, Dec 08, 2004 at 09:06:58PM +0100, Max Laier wrote:
> Any reason you didn't include the following (also part
> of OpenBSD rev. 1.47)?:
>=20
I developed it independently of OpenBSD, and only later
found that OpenBSD also had it, so I missed this part.
It's indeed needed.
> | /*
> | * make sure to set rt->rt_ifa to the interface
> | * address we are using, otherwise we will have trouble
> | * with source address selection.
> | */
> | ifa =3D &ia->ia_ifa;
> | if (ifa !=3D rt->rt_ifa) {
> | IFAFREE(rt->rt_ifa);
> | ifa->ifa_refcnt++;
> | rt->rt_ifa =3D ifa;
> | }
>=20
>=20
> Updated diff attached. Not sure if it makes any difference?
>=20
Of course it does. Without it, "ping <alias>" comes from
the main address, where it should come from <alias>.
Reviewed. Please commit.
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--ZfOjI3PrQbgiZnxM
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBt235qRfpzJluFF4RAm8QAKCPFKnIlVpJVwId9mRGj6iBYhLKoQCeIhPb
gNHjyU1iix/vGpbU8LoMPgc=
=KQw/
-----END PGP SIGNATURE-----
--ZfOjI3PrQbgiZnxM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041208211121.GB61146>