Date: Mon, 12 Jan 2009 00:25:10 -0800 From: "David O'Brien" <obrien@freebsd.org> To: Christoph Mallon <christoph.mallon@gmx.de> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186504 - head/sbin/mount Message-ID: <20090112082510.GA69194@dragon.NUXI.org> In-Reply-To: <4969A626.6070908@gmx.de> References: <200812262254.mBQMsrbR052676@svn.freebsd.org> <4960FA9A.1090509@gmx.de> <20090111041543.GB17602@dragon.NUXI.org> <4969A626.6070908@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 11, 2009 at 08:56:22AM +0100, Christoph Mallon wrote:
> David O'Brien schrieb:
>> On Sun, Jan 04, 2009 at 07:06:18PM +0100, Christoph Mallon wrote:
>>> I'm pretty sure $SUPERNATURAL_BEING_OF_YOUR_CHOICE killed a kitten for
>>> the ugly hack you added to mount. The moment you overflow a buffer, you
>>> are in no man's land and there's no escape. I appended a patch, which
>>> solves this issue once and for all: The argv array gets dynamically
>>> expanded, when its limit is reached.
>>> Please - for all kittens out there - commit this patch.
>>
>> Hi Christoph,
>> Unfortunately your patch doesn't work.
>> For a 'ufs' file system listed in /etc/fstab
>> $ umount /foo
>> $ mount /foo
>> Does not work.
>
> Why haven't you told me earlier?
Wow, wish I did have the gift to know something before I know something.
Especially tomorrow's lotto #'s. ;-)
> It was a trivial glitch - just a missing
> "--mnt_argc;". I would've corrected it right away. I tested with a CD and
> this takes a different code path, which does not trigger the problem.
> Attached is the corrected patch.
Actually this version doesn't work either.
Trying to mount root from ufs:/dev/ad4s1a
<fsck of all UFS's in /etc/fstab>
..
usage: mount [-t fstype] [-o options] target_fs mount_point
Mounting /etc/fstab filesystems failed, startup aborted
ERROR: ABORTING BOOT (sending SIGTERM to parent)!
Your over use of global variables made my adult cat cry in pain.
Too bad you didn't at least follow the lead of what I committed.
I've committed something in the spirit of your patches. I hope
that suits everyone.
--
-- David (obrien@FreeBSD.org)
Q: Because it reverses the logical flow of conversation.
A: Why is top-posting (putting a reply at the top of the message) frowned upon?
Let's not play "Jeopardy-style quoting"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090112082510.GA69194>