Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jan 2016 09:12:41 +0000 (UTC)
From:      Andrew Rybchenko <arybchik@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r293899 - head/sys/dev/sfxge/common
Message-ID:  <201601140912.u0E9CfXR022737@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: arybchik
Date: Thu Jan 14 09:12:40 2016
New Revision: 293899
URL: https://svnweb.freebsd.org/changeset/base/293899

Log:
  sfxge: cleanup: adjust efx_mcdi_get_port_modes() comment for clarity
  
  Fix an explanatory comment which did not explain very well.
  
  Submitted by:   Richard Houldsworth <rhouldsworth at solarflare.com>
  Reviewed by:    gnn
  Sponsored by:   Solarflare Communications, Inc.
  MFC after:      2 days
  Differential Revision: https://reviews.freebsd.org/D4916

Modified:
  head/sys/dev/sfxge/common/hunt_nic.c

Modified: head/sys/dev/sfxge/common/hunt_nic.c
==============================================================================
--- head/sys/dev/sfxge/common/hunt_nic.c	Thu Jan 14 09:11:48 2016	(r293898)
+++ head/sys/dev/sfxge/common/hunt_nic.c	Thu Jan 14 09:12:40 2016	(r293899)
@@ -112,7 +112,10 @@ efx_mcdi_get_port_modes(
 		goto fail1;
 	}
 
-	/* Accept pre-Medford size (8 bytes - no CurrentMode field) */
+	/*
+	 * Require only Modes and DefaultMode fields.
+	 * (CurrentMode field was added for Medford)
+	 */
 	if (req.emr_out_length_used <
 	    MC_CMD_GET_PORT_MODES_OUT_CURRENT_MODE_OFST) {
 		rc = EMSGSIZE;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201601140912.u0E9CfXR022737>