Date: Thu, 2 Apr 2015 13:13:49 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r382977 - head/security/softhsm Message-ID: <20150402131349.72ea0182@kalimero.tijl.coosemans.org> In-Reply-To: <201504020012.t320Cj4P097842@svn.freebsd.org> References: <201504020012.t320Cj4P097842@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--MP_/jScke2AY4HXiKdtZwVNitAb Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline On Thu, 2 Apr 2015 00:12:45 +0000 (UTC) Bryan Drewery <bdrewery@FreeBSD.org> wrote: > Author: bdrewery > Date: Thu Apr 2 00:12:44 2015 > New Revision: 382977 > URL: https://svnweb.freebsd.org/changeset/ports/382977 > > Log: > Thanks for breaking my domain > > Modified: > head/security/softhsm/Makefile > > Modified: head/security/softhsm/Makefile > ============================================================================== > --- head/security/softhsm/Makefile Thu Apr 2 00:12:13 2015 (r382976) > +++ head/security/softhsm/Makefile Thu Apr 2 00:12:44 2015 (r382977) > @@ -16,6 +16,9 @@ LIB_DEPENDS= libbotan-1.10.so:${PORTSDIR > libsqlite3.so:${PORTSDIR}/databases/sqlite3 > > GNU_CONFIGURE= yes > +# !!!!!!!!!!!! > +# Changing the localstatedir is a huge POLA violation. Please leave it alone. > +# !!!!!!!!!!!!!! > CONFIGURE_ARGS= --with-botan=${LOCALBASE} --with-sqlite3=${LOCALBASE} \ > --localstatedir=/var But surely you agree that using PREFIX/var instead of /var is a bug and ports that do so need to be fixed? The attached patch adds --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir). Maybe that would be better to prevent this problem in the future. --MP_/jScke2AY4HXiKdtZwVNitAb Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=b.p.m.localstatedir.patch Index: Mk/bsd.port.mk =================================================================== --- Mk/bsd.port.mk (revision 382989) +++ Mk/bsd.port.mk (working copy) @@ -813,7 +813,8 @@ FreeBSD_MAINTAINER= portmgr@FreeBSD.org # Default: ${PREFIX} # CONFIGURE_ARGS # - Pass these args to configure if ${HAS_CONFIGURE} is set. -# Default: "--prefix=${GNU_CONFIGURE_PREFIX} --infodir=${PREFIX}/${INFO_PATH} +# Default: "--prefix=${GNU_CONFIGURE_PREFIX} +# --infodir=${PREFIX}/${INFO_PATH} --localstatedir=/var # --mandir=${MANPREFIX}/man --build=${CONFIGURE_TARGET}" if # GNU_CONFIGURE is set, "CC=${CC} CFLAGS=${CFLAGS} # PREFIX=${PREFIX} INSTALLPRIVLIB=${PREFIX}/lib @@ -2709,6 +2710,9 @@ HAS_CONFIGURE= yes SET_LATE_CONFIGURE_ARGS= \ _LATE_CONFIGURE_ARGS="" ; \ + if ./${CONFIGURE_SCRIPT} --help 2>&1 | ${GREP} -- --localstatedir > /dev/null; then \ + _LATE_CONFIGURE_ARGS="$${_LATE_CONFIGURE_ARGS} --localstatedir=/var" ; \ + fi ; \ if [ ! -z "`./${CONFIGURE_SCRIPT} --help 2>&1 | ${GREP} -- '--mandir'`" ]; then \ _LATE_CONFIGURE_ARGS="$${_LATE_CONFIGURE_ARGS} --mandir=${GNU_CONFIGURE_MANPREFIX}/man" ; \ fi ; \ --MP_/jScke2AY4HXiKdtZwVNitAb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150402131349.72ea0182>