Date: Mon, 17 Apr 2023 07:30:21 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "Stephen J. Kiernan" <stevek@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 6ae8d57652fa - main - mac_veriexec: add mac_priv_grant check for NODEV Message-ID: <8180B6AE-D70B-443D-80BA-1667E4642854@freebsd.org> In-Reply-To: <ZDzdiRLxyEzDqRPq@FreeBSD.org> References: <202304162314.33GNEwXd039914@gitrepo.freebsd.org> <C919D121-5342-4A3A-8CEB-07B9346D8024@freebsd.org> <ZDzdiRLxyEzDqRPq@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 Apr 2023, at 06:47, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > Jessica, > > Please don't overquote: you complain about commit log, but included the > commit diff in you reply. Why? This is quote annoying on slow networks > and could cost people some cash on metered connection. Seriously? I’m hardly the only one to do that sometimes, and there’s no rule that I know of against it. I only trim when things get unwieldy, but I’m not going to trim for a +45/-2 diff. My whole email was 7 KiB *including* headers, with the commit diff being about half that, and it’s 2023. This is quite an outrageous complaint to make in my opinion and I question why you’re going after me rather than anyone else, especially when it’s about 3-4 KiB. Your complaint is already about 5% of that, and this response is about 15%, so between them that’s 20% of the complained-about amount exchanged again. That’s how tiny the amount of data you’re complaining about is. > On Mon, Apr 17, 2023 at 12:40:07AM +0100, Jessica Clarke wrote: >> ... >> Hi Steve, >> I see you've made a bunch of commits over the past few days that suffer >> from not following the proper commit message formatting outlined in the >> Committer's Guide > > What's exactly wrong with them? They appear more elaborate and detailed > than usual, I like this. * The trailers shouldn’t have blank lines between them * It’s Reviewed by, not Reviewers * Subscribers isn’t a thing * Some had Summary: as the first line of the body These are all just a case of taking Phabricator’s auto-generated commit message and pushing that without taking the time to turn it into a message appropriate for FreeBSD. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8180B6AE-D70B-443D-80BA-1667E4642854>