Date: Fri, 14 Mar 2008 10:21:37 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: arch@FreeBSD.org Subject: BUS_DMA_ISA unused, planning on removing Message-ID: <20080314.102137.-2034679600.imp@bsdimp.com>
next in thread | raw e-mail | index | archive | help
----Next_Part(Fri_Mar_14_10_21_37_2008_059)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Greetings,
It appears that BUS_DMA_ISA is unused:
find . -name \*.c -o -name \*.h | xargs egrep BUS_DMA_ISA
./ia64/isa/isa_dma.c: /*flags*/BUS_DMA_ISA,
./sys/bus_dma.h:#define BUS_DMA_ISA 0x400 /* map memory for AXP ISA dma */
I talked to Marcel, and he's cool with removing it. Can anybody see a
reason not to GC this?
Warner
----Next_Part(Fri_Mar_14_10_21_37_2008_059)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="bus-dma-isa.diff"
Index: ia64/isa/isa_dma.c
===================================================================
RCS file: /pe/ncvs/src/sys/ia64/isa/isa_dma.c,v
retrieving revision 1.10
diff -u -r1.10 isa_dma.c
--- ia64/isa/isa_dma.c 9 Jul 2007 04:58:16 -0000 1.10
+++ ia64/isa/isa_dma.c 14 Mar 2008 16:17:39 -0000
@@ -106,7 +106,7 @@
/*filter*/NULL, /*filterarg*/NULL,
/*maxsize*/bouncebufsize,
/*nsegments*/1, /*maxsegz*/0x3ffff,
- /*flags*/BUS_DMA_ISA,
+ /*flags*/0,
/*lockfunc*/busdma_lock_mutex,
/*lockarg*/&Giant,
&dma_tag[chan]) != 0) {
Index: sys/bus_dma.h
===================================================================
RCS file: /pe/ncvs/src/sys/sys/bus_dma.h,v
retrieving revision 1.30
diff -u -r1.30 bus_dma.h
--- sys/bus_dma.h 3 Sep 2006 00:26:17 -0000 1.30
+++ sys/bus_dma.h 14 Mar 2008 16:17:17 -0000
@@ -101,7 +101,6 @@
*/
#define BUS_DMA_NOWRITE 0x100
#define BUS_DMA_NOCACHE 0x200
-#define BUS_DMA_ISA 0x400 /* map memory for AXP ISA dma */
/* Forwards needed by prototypes below. */
struct mbuf;
----Next_Part(Fri_Mar_14_10_21_37_2008_059)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080314.102137.-2034679600.imp>