Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Jan 2013 21:35:26 +0000 (UTC)
From:      Jim Harris <jimharris@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r245136 - head/sys/dev/nvme
Message-ID:  <201301072135.r07LZQbc092661@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jimharris
Date: Mon Jan  7 21:35:25 2013
New Revision: 245136
URL: http://svnweb.freebsd.org/changeset/base/245136

Log:
  Revert r244549.
  
  This change was originally intended to account for test kthreads under
  the nvmecontrol process, but jhb indicated it may not be safe to
  associate kthreads with userland processes and this could have
  unintended consequences.
  
  I did not observe any problems with this change, but my testing didn't
  exhaust the kinds of corner cases that could cause problems.  It is not
  that important to account for these test threads under nvmecontrol, so I
  am just reverting this change for now.
  
  On a related note, the part of this patch for <= 7.x fails compilation
  so reverting this fixes that too.
  
  Suggested by: jhb

Modified:
  head/sys/dev/nvme/nvme_test.c

Modified: head/sys/dev/nvme/nvme_test.c
==============================================================================
--- head/sys/dev/nvme/nvme_test.c	Mon Jan  7 20:36:51 2013	(r245135)
+++ head/sys/dev/nvme/nvme_test.c	Mon Jan  7 21:35:25 2013	(r245136)
@@ -287,10 +287,10 @@ nvme_ns_test(struct nvme_namespace *ns, 
 	for (i = 0; i < io_test->num_threads; i++)
 #if __FreeBSD_version >= 800004
 		kthread_add(fn, io_test_internal,
-		    curproc, NULL, 0, 0, "nvme_io_test[%d]", i);
+		    NULL, NULL, 0, 0, "nvme_io_test[%d]", i);
 #else
 		kthread_create(fn, io_test_internal,
-		    curproc, 0, 0, "nvme_io_test[%d]", i);
+		    NULL, 0, 0, "nvme_io_test[%d]", i);
 #endif
 
 	tsleep(io_test_internal, 0, "nvme_test", io_test->time * 2 * hz);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301072135.r07LZQbc092661>