Date: Sat, 5 Oct 2013 11:32:14 GMT From: Mamoru Iwaki <1wkmmr@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/182680: set-get confusion in a patch Message-ID: <201310051132.r95BWEdl083069@oldred.freebsd.org> Resent-Message-ID: <201310051140.r95Be0r5012970@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 182680
>Category: ports
>Synopsis: set-get confusion in a patch
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 05 11:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Mamoru Iwaki
>Release: FreeBSD 9.2-STABLE
>Organization:
>Environment:
>Description:
Re: # $FreeBSD: haed/audio/xoscope/Makefile 326090 2013-09-02 21:16:30Z
bapt $
I have just looked around audio/xoscope, not compiling it yet. Then, I
found a strange line in files/patch-ser_unix.c, as follows:
34 +#ifdef BSD
35 + if (tcgetattr(fd, &svbuf) < 0 ) {
36 +#else
37 if (ioctl(fd, TCSETA, &svbuf) < 0) {
38 +#endif
I wonder tcgetattr(...) in line 35 should be tcsetattr(...).
Cheers
>How-To-Repeat:
>Fix:
I believe that the line 35 of files/patch-ser_unix.c should be 'set' as follows.
35 + if (tcsetattr(fd, &svbuf) < 0 ) {
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310051132.r95BWEdl083069>