Date: Tue, 10 Jun 2008 18:02:55 +0200 From: "Paul B. Mahol" <onemda@gmail.com> To: "Coleman Kane" <cokane@freebsd.org> Cc: freebsd-current@freebsd.org, thompsa@freebsd.org Subject: Re: Call for Testers: Convert watchdog spinlock into a sleepable mutex in if_ndis Message-ID: <3a142e750806100902t7a2cddefp71eee2ea5eca55ae@mail.gmail.com> In-Reply-To: <1213102786.1547.3.camel@localhost> References: <1212870158.1724.25.camel@localhost> <3a142e750806071855wb9f4cddk9be25e8c0f3d4984@mail.gmail.com> <1213013020.25641.3.camel@localhost> <1213026755.1628.25.camel@localhost> <3a142e750806092016u34fcd515v7022aa6a0a034e17@mail.gmail.com> <1213101246.1588.5.camel@localhost> <3a142e750806100556q546df348j4d5cb06bfe2bf286@mail.gmail.com> <1213102786.1547.3.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Works fine for me. No regressions encountered yet. On 6/10/08, Coleman Kane <cokane@freebsd.org> wrote: > On Tue, 2008-06-10 at 14:56 +0200, Paul B. Mahol wrote: >> On 6/10/08, Coleman Kane <cokane@freebsd.org> wrote: >> > On Tue, 2008-06-10 at 05:16 +0200, Paul B. Mahol wrote: >> >> On 6/9/08, Coleman Kane <cokane@freebsd.org> wrote: >> >> > Ignore the previous patch (#2) and try this one instead: >> >> > * >> >> > http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx3.patch >> >> > >> >> >> >> Fine for me, LOR appear any more. >> > >> > Thanks for the report. >> > >> >> >> >> BTW: I'm dont like first line showing over and over again. It would be >> >> nice >> >> if that clueless message goes away. >> > >> > Is this a new message introduced with my changes? >> No, it is not. Thanks for patch(es). >> > > I've got one more for you to try: > * > http://people.freebsd.org/~cokane/patches/if_ndis-spinlock-to-mtx4.patch > > It removes the locking inside the ndis_tick function altogether, and > just relies upon ndis_ticktask, ndis_resettask, and ndis_starttask to > perform the appropriate locking (which they appear to have been written > to do already). This might improve concurrency even more (and probably > get rid of some mutex recursions). > > -- > Coleman Kane >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a142e750806100902t7a2cddefp71eee2ea5eca55ae>