Date: Tue, 7 Apr 2020 12:46:26 +0000 (UTC) From: Leandro Lupori <luporl@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r359687 - head/stand/powerpc/ofw Message-ID: <202004071246.037CkQwM003258@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: luporl Date: Tue Apr 7 12:46:26 2020 New Revision: 359687 URL: https://svnweb.freebsd.org/changeset/base/359687 Log: [PPC] Fix loader call to instantiate-rtas OpenFirmware (OF) method instantiate-rtas was being called with a wrong rtas-base-address argument. It must use the memory that is already being allocated to this end instead. This issue was causing QEMU netboot to hang when building the FDT from OF DT. Reviewed by: jhibbits Sponsored by: Eldorado Research Institute (eldorado.org.br) Differential Revision: https://reviews.freebsd.org/D24313 Modified: head/stand/powerpc/ofw/ofwfdt.c Modified: head/stand/powerpc/ofw/ofwfdt.c ============================================================================== --- head/stand/powerpc/ofw/ofwfdt.c Tue Apr 7 03:19:00 2020 (r359686) +++ head/stand/powerpc/ofw/ofwfdt.c Tue Apr 7 12:46:26 2020 (r359687) @@ -120,7 +120,7 @@ ofwfdt_fixups(void *fdtp) /* Instantiate RTAS */ rtas = OF_open(path); base = 0; - OF_call_method("instantiate-rtas", rtas, 1, 1, (cell_t)rtas, + OF_call_method("instantiate-rtas", rtas, 1, 1, (cell_t)rtasmem, &base); /* Store info to FDT using Linux convention */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004071246.037CkQwM003258>