Date: Mon, 8 Aug 2016 00:59:31 +0100 From: Bruce Simpson <bms@fastmail.net> To: Peter Jeremy <peter@rulingia.com>, Hans Petter Selasky <hps@selasky.org> Cc: Adrian Chadd <adrian@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303811 - in head/sys: net net80211 Message-ID: <32531e89-85fa-6012-6a3e-1e6a42843dc0@fastmail.net> In-Reply-To: <20160807192333.GA79784@server.rulingia.com> References: <201608070348.u773mXXt030939@repo.freebsd.org> <46183559-343f-401b-6471-3822e3383a50@selasky.org> <20160807192333.GA79784@server.rulingia.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/08/16 20:23, Peter Jeremy wrote: >> On 08/07/16 05:48, Adrian Chadd wrote: >>> +#define ETHER_IS_BROADCAST(addr) \ ... > IMHO, Adrian's code is clearer and micro-optimisations like this belong > in the complier, not the code. *cough* *cough* 2007 wants its patch back. https://people.freebsd.org/~bms/dump/old/latest-8021p.diff The whole point of using bcmp() was to allow it to be inlined by the compiler for the target arch, rather than forcing it to play guessing games with (lowest-common-denominator machine-word-size) integer accesses. ETHER_IS_MULTICAST(), by contrast, only needs to check a single bit in the 48-bit MAC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32531e89-85fa-6012-6a3e-1e6a42843dc0>