Date: Sun, 08 Jul 2018 15:03:07 -0700 From: Daniel Engel <daniel@ftml.net> To: freebsd-stable@freebsd.org Subject: RE: NFS 4.1 RECLAIM_COMPLETE FS failed error Message-ID: <1531087387.2543270.1433935616.5272EA26@webmail.messagingengine.com>
next in thread | raw e-mail | index | archive | help
Hi,
I am setting up an environment with FreeBSD 11.1 sharing a ZFS datastore to vmware ESXI 6.7. There were a number of errors with NFS 4.1 sharing that I didn't understand until I found the following thread.
<https://lists.freebsd.org/pipermail/freebsd-stable/2018-March/088486.html>;
I traced the commits that Rick has made since that thread and merged them 'head' into 'stable':
'svnlite checkout http://svn.freebsd.org/base/release/11.1.0/'
'svnlite merge -c 332790 http://svn.freebsd.org/base/head'
'svnlite merge -c 333508 http://svn.freebsd.org/base/head'
'svnlite merge -c 333579 http://svn.freebsd.org/base/head'
'svnlite merge -c 333580 http://svn.freebsd.org/base/head'
'svnlite merge -c 333592 http://svn.freebsd.org/base/head'
'svnlite merge -c 333645 http://svn.freebsd.org/base/head'
'svnlite merge -c 333766 http://svn.freebsd.org/base/head'
'svnlite merge -c 334396 http://svn.freebsd.org/base/head'
'svnlite merge -c 334492 http://svn.freebsd.org/base/head'
'svnlite merge -c 327674 http://svn.freebsd.org/base/head'
That completely fixed the connection instability, but the NFS share was still mounting read-only with a RECLAIM_COMPLETE error. So, I manually applied the first patch from the previous thread and everything started working:
--- fs/nfsserver/nfs_nfsdserv.c.savrecl 2018-02-10 20:34:31.166445000 -0500
+++ fs/nfsserver/nfs_nfsdserv.c 2018-02-10 20:36:07.947490000 -0500
@@ -4226,10 +4226,9 @@ nfsrvd_reclaimcomplete(struct nfsrv_desc
goto nfsmout;
}
NFSM_DISSECT(tl, uint32_t *, NFSX_UNSIGNED);
+ nd->nd_repstat = nfsrv_checkreclaimcomplete(nd);
if (*tl == newnfs_true)
- nd->nd_repstat = NFSERR_NOTSUPP;
- else
- nd->nd_repstat = nfsrv_checkreclaimcomplete(nd);
+ nd->nd_repstat = 0;
The question is: Did I miss something? Is there an alternate change already in SVN that does the same thing better, or is there some corner case preventing this patch from being finalized that I just haven't run into yet?
Thanks,
Daniel Engel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1531087387.2543270.1433935616.5272EA26>