Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 Apr 2021 15:20:24 +0200
From:      Mathieu Arnold <mat@freebsd.org>
To:        Mateusz Piotrowski <0mp@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: b080275ea6e0 - main - shells/modernish: Disable failing install-time tests
Message-ID:  <20210426132024.c32545nmvsqzkzzw@aching.in.mat.cc>
In-Reply-To: <202104261222.13QCMYcu044887@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Mon, Apr 26, 2021 at 12:22:34PM +0000, Mateusz Piotrowski wrote:
> The branch main has been updated by 0mp:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=b080275ea6e0c79e0b94974192eb6fe582180614
> 
> commit b080275ea6e0c79e0b94974192eb6fe582180614
> Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
> AuthorDate: 2021-04-26 12:20:59 +0000
> Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
> CommitDate: 2021-04-26 12:20:59 +0000
> 
>     shells/modernish: Disable failing install-time tests
>     
>     This issue has been reported upstream:
>     https://github.com/modernish/modernish/issues/10
> ---
>  shells/modernish/Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/shells/modernish/Makefile b/shells/modernish/Makefile
> index 9c9a1e4958b7..096f3e312a7c 100644
> --- a/shells/modernish/Makefile
> +++ b/shells/modernish/Makefile
> @@ -16,10 +16,15 @@ NO_BUILD=	yes
>  
>  OPTIONS_DEFINE=	DOCS EXAMPLES
>  
> +post-extract:
> +	${MV} ${WRKSRC}/lib/modernish/cap/BUG_DEVTTY.t ${WRKDIR}
> +
>  do-install:
>  	cd ${WRKSRC} && \
>  	${SETENV} ${MAKE_ENV} ${SH} -x ./install.sh -d ${PREFIX} -D ${STAGEDIR} -n -s ${SH}
>  
> +	${MV} ${WRKDIR}/BUG_DEVTTY.t ${STAGEDIR}${PREFIX}/lib/modernish/cap/BUG_DEVTTY.t

You should never install a file with MV, you always use one of the
INSTALL_* macros.

-- 
Mathieu Arnold

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmCGvhNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgK4lxAAshBw10ZQWFN3U9TTfNj+kQgdYGn5Insm/ZA0aysmBzLZKW92Ot3+I5zr
qkDiIR5DCmzz9lsrOAHtSmNY+TT8ukF2FH6JHabVgqAjm/qNEsB4N7uEJe6Rb0wN
IG/MEXqmJjidZ7blEajXao7Gpl2UapGZcWpKEdFPJpBInNXHINjIS73he6CK4Paa
TeMYIlRPMkY03KBShrnImDwBS2ItJs648McIiKVLlXolP5xc8Ia3r68wMxLgzFQe
IWs44ON59p7pcvSInZEXLLYQGN1IfZQa7C45NxAMwbe9dwH9ULOz5fTFBVRzfBgP
6kG6Ahk2kqm6l9fDNcCTY6h3anYs98aKlRn1Ku7CfKD2SsyZyFmHtGtne/G5EA5g
wrWuhbugt/zxYK+uDkkGL7oRwc85HFDRHV6UZt7a04IQ1y+6JXRLDDy5qSAV019I
KiWMREaYnt8Lp44K8hBkQi4jkX9MfU1YlHZnjVcR6JBgP5toKA2aUXsfK3udv5cC
CW3iYl/Ryfzk8eqGVx30xLgTP+dkrHwSL5WmrYkpNMMEz4J+kAnWztVKEewLvcUu
7fN8M03b8qnyM6JcGc3pShWkTEPq8exsjX+CQn4Kfb9YbCQ9IYVNDPYiQTvXEcZq
B3l2TgLXvSAT+qMRydw7cAy2aIyT+yVtwt2THRGBnVq3upbiR74=
=Nks9
-----END PGP SIGNATURE-----
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210426132024.c32545nmvsqzkzzw>