Date: Wed, 20 Aug 2014 13:19:31 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Julian Elischer <julian@freebsd.org>, Davide Italiano <davide@freebsd.org>, freebsd-current <freebsd-current@freebsd.org> Cc: Ed Schouten <ed@80386.nl> Subject: Re: RFC: Remove pty(4) Message-ID: <53F4E6B3.7060209@FreeBSD.org> In-Reply-To: <53F4E544.9070606@freebsd.org> References: <CACYV=-E1BA3rHP5s%2BCs-X-J5CNAaSNxDgqPkgnJu3uUXCyaUGA@mail.gmail.com> <53F4E544.9070606@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 8/20/2014 1:13 PM, Julian Elischer wrote: > On 8/20/14, 11:00 AM, Davide Italiano wrote: >> One of my personal goals for 11 is to get rid of cloning mechanism >> entirely, and pty(4) is one of the few in-kernel drivers still relying >> on such mechanism. >> It's not possible, at least to my understanding, converting pty(4) to >> cdevpriv(9) as happened with other drivers. This is mainly because we >> always need a pair of devices (/dev/ptyXX and /dev/ttyXX) and >> userspace loops over ptyXX and after it successfully opens it tries to >> open the other one with the same suffix. So, having a single device is >> not really enough. >> My option, instead, is that of removing pty(4), which is nothing more >> than a compatibility driver, and move pmtx(4) code somewhere else. >> The main drawback of the removal of this is that it makes impossible >> to run FreeBSD <= 7 jails and SSH into them. I personally don't >> consider this a huge issue, in light of the fact that FreeBSD-7 has >> been EOL for a long time, but I would like to hear other people >> comments. >> >> The code review for the proposed change can be found here: >> https://reviews.freebsd.org/D659 >> >> If I won't get any objection I'll commit this in one week time, i.e. >> August 27th. > I agree with Alfred. > breaking old jails is a no no. > many people still use them. Me included. > I sometimes run jails back to 1.1, > not everything works, but enough does to build 1.1 binaries for certain > devices. +1 to keeping compat. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJT9Oa0AAoJEDXXcbtuRpfPBY0H/RvFmD+8k8Z8mV+4+v+TAzAw Gnj3lJ6lrtgYTPKExTFcerpGBZI94JON+laQTBIf8OPFWgzI3ZMWhIIgqr1Lrx9r NbxAMV1xdREt04PWfmLprH7kfxnPJOVXaY2Fa+ozX9r1sByXBtOgnphF9ASiiXOp aRAhH6I1X5ByGNv3KVrImonFXuBhigGMzYmzCV1ZG+FsTIHxX2PC0Wv+JMZYKhfs 1taWe/Gq384AH9xjAjUI2w/FrX2BLyjN8IfbnZGeiwobNikNLDdgbx96S05gep83 Aw3Cz4DZ07lPtnhCNy7Edhmu/Cm+rjIqkwfe8WOonoMDENXmIAKNrNTuFV90ZQM= =VtHH -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53F4E6B3.7060209>