Date: Wed, 12 Feb 2020 19:18:39 -0500 From: Paul Godard <paulgodard@gmail.com> To: Miroslav Lachman <000.fbsd@quip.cz> Cc: elastic@freebsd.org Subject: Re: Beats port update - 7.5.2 Message-ID: <CA%2B8T5Q6vh00ru-vfFwSuThc62uHj6mqZGyGy0b5Q3pWbnDP_TA@mail.gmail.com> In-Reply-To: <cce8d2e4-69bd-08c3-64e9-7b365bc9a9f9@quip.cz> References: <CA%2B8T5Q4djCk0Oqxi8Dds7L-49UHT9DhoBOWiOEq=CEoak96Pnw@mail.gmail.com> <cce8d2e4-69bd-08c3-64e9-7b365bc9a9f9@quip.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Miroslav, Thanks for the feedback. I'm polishing up the port right now and will submit a PR along with my poudriere testport logs shortly! Cheers, Paul On Tue, Feb 11, 2020 at 5:49 PM Miroslav Lachman <000.fbsd@quip.cz> wrote: > Paul Godard wrote on 2020/02/11 23:35: > > Hello maintainer(s)! > > > > I've been working on an update to the "beats" port for the past week or > so. > > I've upgraded it to version 7.5.2, and fixed a few things here and > there. I > > wanted to reach out to you as the maintainer(s) of the port to share my > > work and/or understand why you might have kept the current port on > version > > 6.x. > > > > I've been mainly testing PacketBeat and MetricBeat (on FreeBSD 11.2 and > > pfSense 2.4.4, which also happens to run FreeBSD 11.2), but also ensured > > that HeartBeat and FileBeat are working. I've shared this development > port > > with a few other folks just to get better testing results (all of these > > folks are testing this on pfSense 2.4.4 as well). Full disclosure, I > > haven't had the time to test this properly on up-to-date builds of > FreeBSD > > such as 11.3 or 12.x (my goal is to run this on pfSense so I've been > > focusing on FreeBSD 11.2 for that reason). I have compiled and packaged > the > > port on 11.3, but did not spend much time testing it other than ensuring > > each beats application starts up and actually pushes data to ES. > > > > My high-level change log is as follows: > > - Upgraded to 7.5.2 > > - Fixed warnings at compile time (fixed bash to sh test conditions) > > - Cleared up compile/package output (it was quite noisy, portlint doesn't > > like this though) > > - Fixed compile issue with PacketBeat (it's now compiling and working) > > - Fixed packaged dashboards so that they can be installed using "setup > > --dashboards" (depends on python 2.7 to achieve this during port > building - > > python isn't required to run packaged port however) > > - Properly generate and include fields.yml for each beats in package > > - Fixed memory and socket reporting in MetricBeats > > - Updated all beats paths to regroup files as per Elastic's default > > directory layout (but using the equivalent paths for FreeBSD) > > - Changed default beats configs to remove unsupported processors (docker > > and kubernetes) > > > > I'm still testing this port, but I feel like it's getting pretty close to > > being ready for prime-time. I've posted my current SVN diff here if you > > would like to take a peek at my changes: https://pastebin.com/PAQWpmKZ. > > > > Feel free to comment on my changes; I'm by no means an expert at these > > ports (I'm learning though!). If you feel this is good enough to submit a > > PR, let me know, I can take care of that once I'm comfortable with the > > build. Or if you prefer to submit the PR with my SVN diff as the > > maintainer(s), I have no problem with that either... > > Hello, > > first of all - I am not a maintainer. elastic@freebsd.org is a mailing > list account and is supposed to be Elastic maintainers team but it is > not much active. > > The best place to submit your patch for port upgrade is PR in bugzilla. > > Please submit it there: > > https://bugs.freebsd.org/bugzilla/enter_bug.cgi?product=Ports%20%26%20Packages&component=Individual%20Port%28s%29 > > If you tested it with poudriere testport attache log file too. > > I hope someone with commit bit will commit it soon. > > Thank you for your work in Beats upgrade to 7.5! > > Kind regards > Miroslav Lachman >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2B8T5Q6vh00ru-vfFwSuThc62uHj6mqZGyGy0b5Q3pWbnDP_TA>