Date: Sat, 5 Feb 2022 07:17:13 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: Richard Scheffenegger <rscheff@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0c424c90eaa6 - main - tcp: move ECN handling code to a common file Message-ID: <Yf6U%2BVl8oIDYVk%2BS@FreeBSD.org> In-Reply-To: <202202050015.2150FeFE041456@gitrepo.freebsd.org> References: <202202050015.2150FeFE041456@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Richard, On Sat, Feb 05, 2022 at 12:15:40AM +0000, Richard Scheffenegger wrote: R> The branch main has been updated by rscheff: R> R> URL: https://cgit.FreeBSD.org/src/commit/?id=0c424c90eaa6602e07bca7836b1d178b91f2a88a R> R> commit 0c424c90eaa6602e07bca7836b1d178b91f2a88a R> Author: Richard Scheffenegger <rscheff@FreeBSD.org> R> AuthorDate: 2022-02-04 21:25:03 +0000 R> Commit: Richard Scheffenegger <rscheff@FreeBSD.org> R> CommitDate: 2022-02-04 21:54:41 +0000 R> R> tcp: move ECN handling code to a common file R> R> Reduce the burden to maintain correct and R> extensible ECN related code across multiple R> stacks and codepaths. R> R> Formally no functional change. R> R> Incidentially this establishes correct R> ECN operation in one instance. I'm sorry - didn't notice it in the phab review. :( There is no reason to use KMOD_TCPSTAT_INC() in the tcp_ecn.c. Now it is a file statically compiled into kernel, unlike RACK or BBR. It should use just TCPSTAT_INC(). -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yf6U%2BVl8oIDYVk%2BS>