Date: Thu, 12 Jan 2017 00:05:45 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 198377] libc: Invalid size check in load_msgcat() Message-ID: <bug-198377-8-YpidtcDhQy@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-198377-8@https.bugs.freebsd.org/bugzilla/> References: <bug-198377-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198377 Conrad Meyer <cem@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cem@freebsd.org --- Comment #3 from Conrad Meyer <cem@freebsd.org> --- This Coverity warning is sort of dubious. It's true on our 64-bit architectures, where sizeof(size_t) =3D=3D sizeof(off_t); but it's not true= on our 32-bit architectures, where size_t is half as big. I think we should just ignore the CID in Coverity and move on. It would be a pretty major OS bug for st_size to ever be negative, so I don= 't like the proposed patch. If you want to add a KASSERT to sys_stat or kern_= stat that st_size is >=3D 0, I would support that instead. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198377-8-YpidtcDhQy>