Date: Fri, 27 May 2016 15:57:00 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Alan Cox <alc@rice.edu>, Ivan Klymenko <fidaj@ukr.net>, Alan Cox <alc@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300865 - in head/sys: sys vm Message-ID: <0A87E70A-AEDE-47F8-AC92-6A93DD1D02FA@gmail.com> In-Reply-To: <20160527223942.GS38613@kib.kiev.ua> References: <201605271915.u4RJFkEl013139@repo.freebsd.org> <20160527225103.67ae3547@nonamehost.local> <20160527210148.GR38613@kib.kiev.ua> <016BEE0D-05B6-4042-8CD4-471D4D1C9162@gmail.com> <3018B8E4-5E33-49EF-8154-D7D5ECEE8403@gmail.com> <5CAD8DF0-0D56-4EBD-AB93-645B21E3792D@gmail.com> <4318dffc-fef5-2128-74c2-0e97767b36c8@rice.edu> <05E6AFC6-E7B4-45E9-8E5B-C2CDA439D33B@gmail.com> <20160527223942.GS38613@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On May 27, 2016, at 15:39, Konstantin Belousov <kostikbel@gmail.com> wrote: > > On Fri, May 27, 2016 at 03:32:48PM -0700, Ngie Cooper (yaneurabeya) wrote: >> >>> On May 27, 2016, at 14:26, Alan Cox <alc@rice.edu> wrote: >>> >>> On 05/27/2016 16:22, Ngie Cooper (yaneurabeya) wrote: >>>>> On May 27, 2016, at 14:21, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: >>>>>> I added #include <sys/types.h> to zfs/arc.c in r300870 ??? it was missing from the file. Looking into drm2 and fed. >>>>> Oy. Bad test before I did the fix. The issue was libzpool -_- (just saw alc???s comment)??? I???ll fix my commit.. >>>> Actually, I???ll just revert my commit and report back about whether or not your patch worked kib. >>> >>> >>> Revert and remove the vm_pageout.h #include from arc.c. >> >> Confirmed. Reverting r300870 and applying kib???s diff passes buildworld. Please commit the patch. > > There was Alan' suggestion to remove vm_pageout.h at all. > > Either way, commit my patch, or preferrably Alan' suggested changes yourself. I double-checked alc’s suggestion and it passed buildworld/buildkernel with ZFS on. I committed his proposed change in r300884. Thank you very much for the help, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXSNC8AAoJEPWDqSZpMIYVcnIQAIwK+ivpkenxOz0yCT+/RfjC 86uZ0dNT6funS00n1cNFnmeR55D6BFoR9Xeku1m9XR5U3Z6hn8Pyrxy7a9Vd5kDf 6oMlhg8PCNonrhXZ08SfxmDRRugCf8u7z0g4cSpSVmAlIIE8AQjmYi15JaacSQmH CV+m1Xknd5Zi3/EZJ+nJhHGysHerN31jXFJTqhpXcYeSmyUf9VvdXTRhbnF+/zGw fubMO58yGn+EEBDX6EeuHndOmeSS89zXJlF7xGSqPAbODNhRRTXi/gbCrNjv8Du9 KNIHmXe5MOnWPg8AL3ZQdWo6gfrEcaRV2A47rU8q9UTOa/jQ0HsTGMm6/fMcTRpg a5UyMz/0udUNawvckWaOyBUAjInrlZ50n9AzfNS9VWsb3qr3LRaG2xBMeKqxKh0+ SuNfZqYMaS4q/wAHwq1OhQuw26Hb7B9ObQKwWlNzdCh9YZw42FJELlDt7lTNL1bQ fxuNHvuVm1IwEX8XHczeGtvmdzRyjKfr4NKNiN+8C2EeCDlH0s6TZ+bS1k+Hi2Vb YSPPCxM9NYWN3SiqhVN91CNUzfqXi0zjOENiUtD/l2yCjoi2glmd8CKRxsgwiVIk pUR2dXAWaBFfxsM97hfcSVOBybsawQ6ZbFKerJFa2nkONx6N9B3OxsQqaboVsLZY IZL9GhzozCfLQaLaKRmC =p4PG -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0A87E70A-AEDE-47F8-AC92-6A93DD1D02FA>