Date: Sat, 31 Jan 2009 23:14:58 +0100 (CET) From: Gerald Pfeifer <gerald@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/131228: portlint: avoid false positive regarding /boot/loader.conf Message-ID: <200901312214.n0VMEwF2076140@sputnik1.dbai.tuwien.ac.at> Resent-Message-ID: <200901312220.n0VMK2iF064682@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 131228
>Category: ports
>Synopsis: portlint: avoid false positive regarding /boot/loader.conf
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Jan 31 22:20:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Gerald Pfeifer
>Release: FreeBSD 7.1-RELEASE i386
>Organization:
>Environment:
>Description:
Current versions of portlint issue the following warning for
lang/gcc43 and similar ports:
WARN: Makefile: possible use of absolute pathname "/boot/loader.conf)".
This is correct in that this is indeed an absolute pathname,
alas it is a false positive in the sense that the use of this
here is fair: this really is an absolute name that needs to be
specified like this.
>How-To-Repeat:
cd $PORTSDIR/lang/gcc43 ; portlint -C
>Fix:
Proposed patch, tested on my side, and making it easier to add
any further exceptions if needed.
--- /usr/local/bin/portlint 2009-01-31 12:51:17.000000000 +0100
+++ portlint 2009-01-31 23:10:22.942160000 +0100
@@ -2994,7 +2994,9 @@
$i = '';
}
}
- if ($i ne '') {
+ # Ignore some (otherwise) false positives.
+ if ($i ne ''
+ && $i !~ '/boot/loader.conf' ) {
$i =~ s/\s.*$//;
$i =~ s/['"].*$//; #'
$i = substr($i, 0, 20) . '...' if (20 < length($i));
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901312214.n0VMEwF2076140>