Date: Fri, 13 Mar 2009 14:40:20 +0100 From: Hans Petter Selasky <hselasky@freebsd.org> To: freebsd-usb@freebsd.org Cc: usb@freebsd.org, Weongyo Jeong <weongyo@freebsd.org>, Robert Watson <rwatson@freebsd.org>, thompsa@freebsd.org Subject: Re: USB support in NDIS -- IFF_NEEDSGIANT? Message-ID: <200903131440.22224.hselasky@freebsd.org> In-Reply-To: <alpine.BSF.2.00.0903131136500.61873@fledge.watson.org> References: <alpine.BSF.2.00.0902161129060.5806@fledge.watson.org> <20090217052121.GB86244@weongyo.cdnetworks.kr> <alpine.BSF.2.00.0903131136500.61873@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 13 March 2009, Robert Watson wrote: > On Tue, 17 Feb 2009, Weongyo Jeong wrote: > >> As you know, I've been gradually working to eliminate all non-MPSAFE > >> network device driver infrastructure for 8.0, having removed non-MPSAFE > >> network protocol infrastructure in 7.0. In reviewing remaining drivers > >> using IFF_NEEDSGIANT, I spotted this in the NDIS code: > > ... > > >> Having taken a glance, it looks like this was added specifically to > >> support USB devices attached via NDIS. > > > > AFAIK all of usb wireless drivers had it so I couldn't avoid it when I > > had implemented. > > > >> With the new USB code, are NDIS drivers still supported? > > > > I think that it would be supported at 8.0 > > > >> And in the new world order, is this IFF_NEEDSGIANT still required? > > > > Probably we can remove the IFF_NEEDSGIANT flags at the new USB code. > > > >> Can I simply remove it once the old USB code is on the way out the door? > > > > IMHO yes I think. > > Dear all: > > A few weeks have passed, so I wanted to check in and see how this project > was going -- are we at a point yet where removing IFF_NEEDSGIANT won't > cause significant loss of functionality? I think both NDIS USB and USB Ethernet/WLAN drivers have been made Giant-free. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903131440.22224.hselasky>