Date: Mon, 11 Oct 2004 13:56:56 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Brian Feldman <green@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c Message-ID: <200410111356.56415.jhb@FreeBSD.org> In-Reply-To: <200410090816.i998Gbs5076009@repoman.freebsd.org> References: <200410090816.i998Gbs5076009@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 09 October 2004 04:16 am, Brian Feldman wrote: > green 2004-10-09 08:16:37 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_witness.c > Log: > Don't "implicitly order all sleep locks before spin locks" in witness > when the spin lock in question isn't -- it's the critical_enter() that > KDB set. No more panic in DDB for console -> syscons -> tty -> knote > operations. Thanks for breaking witness. A better choice would be to fix kdb_printf() instead of just papering over the problem. Having KDB block on a lock will have all sorts of bad results and all this does is hide the warning. Please revert. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410111356.56415.jhb>