Date: Fri, 29 Nov 2002 16:37:42 +0100 From: Christopher Sharp <csharp@gmx.net> To: freebsd-audit@freebsd.org Subject: patch for the make regression test Message-ID: <20021129153742.GA11955@gmx.net>
next in thread | raw e-mail | index | archive | help
--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hello,
as I stated in an email I wrote to -current yesterday I'm not really
happy with the output of the regression test for make which is run before
every command in src. Attached you can find a patch to make it
IMHO nicer and shorter. I would be really glad if something like
this or this patch could get commited.
Comments ?
- Christopher
--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="make.Makefile.patch"
--- Makefile.old Thu Nov 28 14:21:32 2002
+++ Makefile Fri Nov 29 16:30:57 2002
@@ -19,28 +19,29 @@
NIL=
all:
- @echo "Running test variables"
+ @echo "Doing regression tests for make:"
+ @echo -n "Running test variables... "
@echo 1:${DATA1} 2:${DATA2} 3:${DATA3} 4:${DATA4} 5:${DATA5} | \
diff -u ${.CURDIR}/regress.variables.out - || ${MAKE} failure
- @echo "PASS: Test variables detected no regression, output matches."
- @echo "Running test targets"
+ @echo "ok"
+ @echo -n "Running test targets... "
@${MAKE} double || ${MAKE} failure
- @echo "PASS: Test targets detected no regression."
- @echo "Running test sysvmatch"
+ @echo "ok"
+ @echo -n "Running test sysvmatch... "
@${MAKE} sysvmatch || ${MAKE} failure
- @echo "PASS: Test sysvmatch detected no regression."
- @echo "Running test lhs_expn"
+ @echo "ok"
+ @echo -n "Running test lhs_expn... "
@! ${MAKE} lhs_expn && true || ${MAKE} failure
- @echo "PASS: Test lhs_expn detected no regression."
- @echo "Running test notdef"
+ @echo "ok"
+ @echo -n "Running test notdef... "
@${MAKE} notdef || ${MAKE} failure
- @echo "PASS: Test notdef detected no regression."
- @echo "Running test modifiers"
+ @echo "ok"
+ @echo -n "Running test modifiers... "
@${MAKE} modifiers || ${MAKE} failure
- @echo "PASS: Test modifiers detected no regression."
- @echo "Running test funny_targets"
+ @echo "ok"
+ @echo -n "Running test funny_targets... "
@${MAKE} funny_targets || ${MAKE} failure
- @echo "PASS: Test funny_targets detected no regression."
+ @echo "ok"
.if make(double)
# Doubly-defined targets. make(1) will warn, but use the "right" one. If it
@@ -91,5 +92,5 @@
.endif
failure:
- @echo "FAIL: Test failed: regression detected. See above."
+ @echo "failed (regression detected)"
@false
--FL5UXtIhxfXey3p5--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021129153742.GA11955>