Date: Mon, 11 Jan 2016 01:13:11 -0500 From: "Michael B. Eichorn" <ike@michaeleichorn.com> To: araujo@FreeBSD.org, Marcelo Araujo <araujobsdport@gmail.com>, Ravi Pokala <rpokala@mac.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Allan Jude <allanjude@freebsd.org> Subject: Re: svn commit: r292788 - in head/sys: geom/part sys Message-ID: <860F7549-231D-4175-AD21-3419E8F9AF92@michaeleichorn.com> In-Reply-To: <CAOfEmZj3zXtYtcXKBES%2Bz0UoEiyAEgW2CpKqQQHdYohmt7cXOQ@mail.gmail.com> References: <201512271812.tBRICD3A044563@repo.freebsd.org> <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> <CAOfEmZj3zXtYtcXKBES%2Bz0UoEiyAEgW2CpKqQQHdYohmt7cXOQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
GUID partition types *are* of use to all. I see no problem keeping track of additional proprietary ids that are in the wild. These are the type codes we use when partioning and examining partition tables, it is useful to know what a partition is even if we cannot read it. The referenced commit by Allan included ids for Microsoft proprietary partitions. This request seems in line with that to me. On January 11, 2016 12:19:34 AM EST, Marcelo Araujo <araujobsdport@gmail.com> wrote: >IMHO, if it can't be something generic that other people can use it, it >is >a NO GO! > >-1 > > >2016-01-11 12:54 GMT+08:00 Ravi Pokala <rpokala@mac.com>: > >> Hi folks, >> >> I have a Panasas-proprietary GPT UUID that I'd like to commit >upstream. >> There's ~zero chance anyone outside of Panasas or our customers would >ever >> see it, but we're trying to reduce gratuitous differences against >upstream, >> and this is a good candidate. When I mentioned this at the November >2015 >> DevSummit, no one there objected. >> >> There was a recent change in this area, which brought up some >questions. >> See below: >> >> -----Original Message----- >> >> >> From: <owner-src-committers@freebsd.org> on behalf of Allan Jude >> <allanjude@FreeBSD.org> >> Date: 2015-12-27, Sunday at 10:12 >> To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, < >> svn-src-head@freebsd.org> >> Subject: svn commit: r292788 - in head/sys: geom/part sys >> >> >Author: allanjude >> >Date: Sun Dec 27 18:12:13 2015 >> >New Revision: 292788 >> >URL: https://svnweb.freebsd.org/changeset/base/292788 >> > >> >Log: >> > Add some additional GPT partition types >> > >> >... >> > >> > Differential Revision: https://reviews.freebsd.org/D3841 >> > >> >... >> > >> >> In that review, there was discussion about the sorting of aliases in >(enum >> g_part_alias). It was originally thought that the aliases needed to >be >> sorted, due to binary searching in g_part_alias_name(). It turned out >that >> g_part_alias_name() did a linear search, so the list didn't strictly >need >> to be sorted. But, there was talk of potentially switching to a >binary >> search later, so Allan went with the sorted version. >> >> ae@ and kib@ voiced some concerns: >> >> From: <owner-src-committers@freebsd.org> on behalf of "Andrey V. >Elsukov" >> <bu7cher@yandex.ru> >> Date: 2015-12-28, Monday at 00:32 >> To: Allan Jude <allanjude@FreeBSD.org>, <src-committers@freebsd.org>, >< >> svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> >> Subject: Re: svn commit: r292788 - in head/sys: geom/part sys >> >> >> > This enum could be used by third-party kernel module and in general >it >> > is not good to change the order of elements here. This can break >`gpart >> > show` output for such modules. Just for the future. :) >> >> >> From: <owner-src-committers@freebsd.org> on behalf of Konstantin >Belousov >> <kostikbel@gmail.com> >> Date: 2015-12-28, Monday at 02:49 >> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> >> Cc: Allan Jude <allanjude@FreeBSD.org>, <src-committers@freebsd.org>, >< >> svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> >> Subject: Re: svn commit: r292788 - in head/sys: geom/part sys >> >> >> > If the enum values are considered part of KBI, then explicit >assignment >> > of the enum values is much preferred. >> >> >> As best as I can tell, nothing in base/head or ports/head looks at >the GPT >> UUIDs or aliases (outside of GEOM_PART itself, of course), so ae@ and >kib@'s >> concerns are not an issue at this time. Therefore, my plan is to >insert the >> new alias and UUID entries into the various enums and lists in-order, >> rather than just appending. Any objections? >> >> Thanks, >> >> Ravi (rpokala@) >> >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to >"svn-src-head-unsubscribe@freebsd.org" >> > > > >-- > >-- >Marcelo Araujo (__)araujo@FreeBSD.org >\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ >Power To Server. .\. /_) >_______________________________________________ >svn-src-head@freebsd.org mailing list >https://lists.freebsd.org/mailman/listinfo/svn-src-head >To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From owner-svn-src-all@freebsd.org Mon Jan 11 06:26:04 2016 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F915A6CE6D; Mon, 11 Jan 2016 06:26:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x230.google.com (mail-pf0-x230.google.com [IPv6:2607:f8b0:400e:c00::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 56F4F1197; Mon, 11 Jan 2016 06:26:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x230.google.com with SMTP id q63so41137659pfb.1; Sun, 10 Jan 2016 22:26:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gek1jTCd9y3CTnOBjcOQkWLbP8A7hE667vOEBbIwsb8=; b=KoeTSSFotsY4cNuZZBJ2i98/ST0Kja1ka/6/o0HJKmsusXgtVy7vIqKAzwOac96ZeI fPtv3dIcPacOm6NCILkQkUGHOXK8P90dtHjPMV0i2In5Dmx1U2QEOfPnYGkcvfqq5r+X r+2mClRBE5uNqhP1YYxzEF3KLnRrEAm2ROir3VgvXOQeQgzNO7p9s2Hrb6crY8HvGSTh v7NnsTMomjPqrOW6XEgcNn/S03pw8a4gJq3OHC6SeBIWZFDdQdZ+oFn0zOqhe3+WxTeY KS5AMgJGRj4WEvaUiClGQCXE7RUJm2OiB3rr0UtG5aIckzFaBjw96g6EzraB9mbMvT0B BKGg== X-Received: by 10.98.68.211 with SMTP id m80mr24030970pfi.117.1452493563848; Sun, 10 Jan 2016 22:26:03 -0800 (PST) Received: from [192.168.20.7] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id ya4sm16911932pab.22.2016.01.10.22.26.01 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 10 Jan 2016 22:26:02 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r293654 - stable/10/sys/boot/efi From: NGie Cooper <yaneurabeya@gmail.com> In-Reply-To: <201601110425.u0B4P464095198@repo.freebsd.org> Date: Sun, 10 Jan 2016 22:26:00 -0800 Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <5DD7E7B9-C73F-423F-8762-3471B18D314F@gmail.com> References: <201601110425.u0B4P464095198@repo.freebsd.org> To: Ed Maste <emaste@freebsd.org> X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Mon, 11 Jan 2016 06:26:04 -0000 > On Jan 10, 2016, at 20:25, Ed Maste <emaste@freebsd.org> wrote: >=20 > Author: emaste > Date: Mon Jan 11 04:25:03 2016 > New Revision: 293654 > URL: https://svnweb.freebsd.org/changeset/base/293654 >=20 > Log: > Move -msoft-float compiler flag into x86/i386 cases to fix ia64 >=20 > Direct commit to stable/10 as ia64 support does not exist in HEAD. >=20 > Modified: > stable/10/sys/boot/efi/Makefile.inc >=20 > Modified: stable/10/sys/boot/efi/Makefile.inc > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- stable/10/sys/boot/efi/Makefile.inc Mon Jan 11 03:30:16 2016 = (r293653) > +++ stable/10/sys/boot/efi/Makefile.inc Mon Jan 11 04:25:03 2016 = (r293654) > @@ -4,17 +4,19 @@ BINDIR?=3D /boot >=20 > .if ${MACHINE_CPUARCH} =3D=3D "i386" > CFLAGS+=3D -march=3Di386 > +CFLAGS+=3D -msoft-float > .endif >=20 > # Options used when building app-specific efi components > # See conf/kern.mk for the correct set of these > -CFLAGS+=3D -ffreestanding -Wformat -msoft-float > +CFLAGS+=3D -ffreestanding -Wformat > LDFLAGS+=3D -nostdlib >=20 > .if ${MACHINE_CPUARCH} =3D=3D "amd64" > CFLAGS+=3D -fshort-wchar > CFLAGS+=3D -mno-red-zone > CFLAGS+=3D -mno-mmx -mno-sse -mno-aes -mno-avx > +CFLAGS+=3D -msoft-float > .endif This unfortunately doesn=E2=80=99t fix gcc :(...=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?860F7549-231D-4175-AD21-3419E8F9AF92>