Date: Sat, 06 Mar 2004 03:28:05 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/mplayer-plugin Makefile Message-ID: <1078561685.30101.8.camel@shumai.marcuscom.com> In-Reply-To: <20040306082200.GA27791@xor.obsecurity.org> References: <200403060733.i267XKd3044611@repoman.freebsd.org> <20040306081037.GA27564@xor.obsecurity.org> <1078561060.30101.3.camel@shumai.marcuscom.com> <20040306082200.GA27791@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, 2004-03-06 at 03:22, Kris Kennaway wrote: > On Sat, Mar 06, 2004 at 03:17:40AM -0500, Joe Marcus Clarke wrote: > > On Sat, 2004-03-06 at 03:10, Kris Kennaway wrote: > > > On Fri, Mar 05, 2004 at 11:33:20PM -0800, Joe Marcus Clarke wrote: > > > > marcus 2004/03/05 23:33:20 PST > > > > > > > > FreeBSD ports repository > > > > > > > > Modified files: > > > > www/mplayer-plugin Makefile > > > > Log: > > > > Add firefox support via WITH_MOZILLA=firefox. Note: this only works for > > > > mplayer-plugin. Setting WITH_MOZILLA=firefox will not work with the > > > > galeon ports. > > > > > > Shouldn't this be WITH_FIREFOX=yes or similar? Most WITH_ and > > > WITHOUT_ variables do not care about the value, and giving them > > > special values makes it difficult to use with configuration tools like > > > 'make config'. > > > > This was done for scaling purposes in the original Mozilla-based ports > > (galeon, galeon2, epiphany). This way, one can specify the mozilla they > > want to use (be it mozilla, mozilla-devel, and one point mozilla-vendor, > > and now firefox). It was easier than defining a large number of macros > > then deciding on precedence. > > OK, going this way, there is precedence for a MOZILLA_PORT variable > (cf APACHE_PORT, GHOSTSCRIPT_PORT) for choosing one of a number of > equivalent choices. I look at converting over to a MOZILLA_PORT, but WITH_MOZILLA predates those other options, and people have grown accustom to it. Joe > > kris -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBASYuVb2iPiv4Uz4cRAnqzAJ4usm5WO8SMf91ZMhtyJZPPft+rCgCeIUj8 wkENLeFovEL4f4jhwSvJVik= =NNlC -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1078561685.30101.8.camel>