Date: Fri, 19 Apr 2019 14:29:23 -0400 From: Alexander Motin <mav@FreeBSD.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <8d763a63-0915-d9f6-1b90-5e902f06ebe4@FreeBSD.org> In-Reply-To: <0F708A9C-D29D-466A-B541-06DB7127349E@gmail.com> References: <201904191544.x3JFijLe075969@repo.freebsd.org> <0F708A9C-D29D-466A-B541-06DB7127349E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19.04.2019 14:09, Enji Cooper wrote: >> On Apr 19, 2019, at 08:44, Alexander Motin <mav@freebsd.org> wrote: >> >> Author: mav >> Date: Fri Apr 19 15:44:45 2019 >> New Revision: 346390 >> URL: https://svnweb.freebsd.org/changeset/base/346390 >> >> Log: >> Change the way FreeBSD GID inheritance is hacked. >> >> I believe previous ifdef caused NULL dereference in later zfs_log_create() >> on attempt to create file inside directory belonging to ephemeral group >> created on illumos, trying to write to log information about GID domain >> of the newly created file, inheriting the ephemeral GID. >> >> This patch reuses original illumos SGID code with exception that due to >> lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBODY >> by another ifdef inside zfs_fuid_map_id(). > > Hi mav@! > I was wondering, does this break ACL mappings with sticky bits for the group ID (or was it broken to begin with)? If the latter, does it make sense to file a bug/add a TODO comment? I don't believe this change should have any visible results for native FreeBSD pools. It does change change handling of some pools coming from illumos, but previous behavior in that case resulted in kernel panic, so anything else is better, while full compatibility is impossible, since FreeBSD has no kernel-side AD UID/GID mapping, used by illumos SMB. Could you better describe what ACL mapping breakage you are talking about? -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8d763a63-0915-d9f6-1b90-5e902f06ebe4>