Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 05 Dec 1996 00:56:05 +0800
From:      Peter Wemm <peter@spinner.dialix.com>
To:        Erich Boleyn <erich@uruk.org>
Cc:        smp@freebsd.org
Subject:   Re: Greater than 2 CPUs... problem with my diff 
Message-ID:  <199612041656.AAA00583@spinner.DIALix.COM>
In-Reply-To: Your message of "Wed, 04 Dec 1996 08:51:15 PST." <E0vVKXT-0002A3-00@uruk.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
Erich Boleyn wrote:
> 
> I just realized the diff I just sent was conceptually wrong (though it
> would probably work for all existing machines, and worked fine for mine).
> The real diff I should have sent for mp_machdep.c is included here, so
> please use that instead!
> 
> -----------------(start cvs diff sys/i386/i386/mp_machdep.c)-----------------
> Index: sys/i386/i386/mp_machdep.c
> ===================================================================
> RCS file: /usr/cvssup/sys/i386/i386/mp_machdep.c,v
> retrieving revision 1.28
> diff -r1.28 mp_machdep.c
> 778c778,779
> < 	/* add another AP to list */
> ---
> > 	/* add another AP to list, if less than max number of CPUs */
> > 	if ( x == (NCPU-1) ) return;
> 780,783d780
> < 	if ( x == NCPU ) {
> < 	    printf( "too many CPUs, increase 'NCPU'\n" );
> < 	    panic( "\n" );
> < 	}
> ------------------(end cvs diff sys/i386/i386/mp_machdep.c)------------------

Umm, where is 'x' initialised?  it's very hard to see exactly what you're
trying to do, a context diff would be a lot better...

Cheers,
-Peter



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612041656.AAA00583>