Date: Thu, 25 Mar 2010 07:49:57 -0400 From: John Baldwin <jhb@freebsd.org> To: Alexander Leidinger <Alexander@leidinger.net> Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review Message-ID: <201003250749.57994.jhb@freebsd.org> In-Reply-To: <20100325105615.10186jr08a5oj00s@webmail.leidinger.net> References: <20100322.125937.278730673160410010.imp@bsdimp.com> <201003241132.29588.jhb@freebsd.org> <20100325105615.10186jr08a5oj00s@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 25 March 2010 5:56:15 am Alexander Leidinger wrote:
> Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 11:32:29
-0400):
>
> > On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote:
> >> Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 10:05:55
> > -0400):
> >>
> >> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote:
> >>
> >> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk
> >> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means
> >> >> that all makeoptions do not propagate to module builds.
> >> >>
> >> >> Any ideas?
> >> >
> >> > Hmmmm. That's odd because 'DEBUG=-g' does work. Ah, I think you
should
> >> > patch kern.post.mk to propogate WITH_CTF to modules. This is how it
works
> >> > for DEBUG now:
> >> >
> >> > .if defined(DEBUG)
> >> > MKMODULESENV+= DEBUG_FLAGS="${DEBUG}"
> >> > .endif
> >>
> >> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk
> >> instead of kernl.post.mk)?
> >
> > No, I think it is fine to treat it the same as DEBUG.
>
> DEBUG is in kern.pre.mk, and thus can be overriden. Currently I have
> WITH_CTF handling in kern.post.mk, and thus it can not be overriden.
> There are some MKMODULESENV things in post.mk already.
Ok.
> On a related note, the LD_CTF_FLAGS thing does not seem to work for
> modules. Reading the man page of ld tells that -g is a noop (the
> switch is ignored). Thus I would prefer to remove the setting of -g
> for ld. Any objections?
Ok.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003250749.57994.jhb>