Date: Mon, 14 Jun 2010 18:11:42 +0000 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Anton Berezin <tobez@FreeBSD.org>, ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: cvs commit: ports/devel/p5-DateTime-Format-Excel Makefile distinfo Message-ID: <4C1670DE.4070202@p6m7g8.com> In-Reply-To: <20100614174430.GA82322@heechee.tobez.org> References: <201006141204.o5EC4q5J002813@repoman.freebsd.org> <4C166555.4020004@p6m7g8.com> <20100614174430.GA82322@heechee.tobez.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/14/10 17:44, Anton Berezin wrote:
> On Mon, Jun 14, 2010 at 05:22:29PM +0000, Philip M. Gollucci wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 06/14/10 12:04, Anton Berezin wrote:
>>> | -BUILD_DEPENDS= ${RUN_DEPENDS}
>>> | -RUN_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/DateTime.pm:${PORTSDIR}/devel/p5-DateTime
>>> | +BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/DateTime.pm:${PORTSDIR}/devel/p5-DateTime
>>> | +RUN_DEPENDS= ${BUILD_DEPENDS}
>> I really thought we were going in the other direction of not setting a
>> depends = to another depends?
I did mis-read the diff. You're moving which dep is assigned to which
for portlint. portlint only checks for one case. Maybe should change that.
>
> This particular commit did not change the status quo. The change was done
> to silence portlint.
ACK.
>
> As for the substance of setting the two to be the same, I am afraid I missed
> the relevant discussion - the one which reached the consensus that it is not
> a good idea. Could you point me towards it?
I can't help you here, but maybe itectu can since he replied. Its done
b/c we don't use := which portlint will also warn about b/c that regex
is wrong. The reason is that later assigning to either will add your
dep to both where you usually only want one. I realize in p5- ports
this is probably not an issue b/c they are really small but hey....
"The only thing people are consistent in is being in consistent."
- --
- ------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer, FreeBSD Foundation
Consultant, P6M7G8 Inc.
Sr. System Admin, Ridecharge Inc.
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iD8DBQFMFnDedbiP+9ubjBwRAjEqAJwPeLZ/Le6KYhjEfqPfPUaJcbxp+wCeLeZa
7toR+XWOyX6Ct6nroHtNJsE=
=m+Iq
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C1670DE.4070202>