Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Sep 2021 16:17:44 GMT
From:      Emmanuel Vadot <manu@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 559f60214b74 - main - dwmmc: Remove dwmmc_setup_bus call from start_cmd
Message-ID:  <202109211617.18LGHiLu036088@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by manu:

URL: https://cgit.FreeBSD.org/src/commit/?id=559f60214b7498ac068c5aa1f2bdecc1610bab53

commit 559f60214b7498ac068c5aa1f2bdecc1610bab53
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2021-09-21 15:52:38 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2021-09-21 16:17:20 +0000

    dwmmc: Remove dwmmc_setup_bus call from start_cmd
    
    There is no need to re-setup the bus before each commands.
    Tested-on:  Rock64, RockPro64
    Reported by:        avg
---
 sys/dev/mmc/host/dwmmc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/dev/mmc/host/dwmmc.c b/sys/dev/mmc/host/dwmmc.c
index df7ac374a265..77c8e42a6150 100644
--- a/sys/dev/mmc/host/dwmmc.c
+++ b/sys/dev/mmc/host/dwmmc.c
@@ -1102,9 +1102,6 @@ dwmmc_start_cmd(struct dwmmc_softc *sc, struct mmc_command *cmd)
 	sc->curcmd = cmd;
 	data = cmd->data;
 
-	if ((sc->hwtype & HWTYPE_MASK) == HWTYPE_ROCKCHIP)
-		dwmmc_setup_bus(sc, sc->host.ios.clock);
-
 #ifndef MMCCAM
 	/* XXX Upper layers don't always set this */
 	cmd->mrq = sc->req;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109211617.18LGHiLu036088>