Date: Sat, 6 Mar 2004 00:33:23 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/www/mplayer-plugin Makefile Message-ID: <20040306083322.GA28004@xor.obsecurity.org> In-Reply-To: <1078561685.30101.8.camel@shumai.marcuscom.com> References: <200403060733.i267XKd3044611@repoman.freebsd.org> <20040306081037.GA27564@xor.obsecurity.org> <1078561060.30101.3.camel@shumai.marcuscom.com> <20040306082200.GA27791@xor.obsecurity.org> <1078561685.30101.8.camel@shumai.marcuscom.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Mar 06, 2004 at 03:28:05AM -0500, Joe Marcus Clarke wrote: > > > > > Add firefox support via WITH_MOZILLA=firefox. Note: this only works for > > > > > mplayer-plugin. Setting WITH_MOZILLA=firefox will not work with the > > > > > galeon ports. > > > > > > > > Shouldn't this be WITH_FIREFOX=yes or similar? Most WITH_ and > > > > WITHOUT_ variables do not care about the value, and giving them > > > > special values makes it difficult to use with configuration tools like > > > > 'make config'. > > > > > > This was done for scaling purposes in the original Mozilla-based ports > > > (galeon, galeon2, epiphany). This way, one can specify the mozilla they > > > want to use (be it mozilla, mozilla-devel, and one point mozilla-vendor, > > > and now firefox). It was easier than defining a large number of macros > > > then deciding on precedence. > > > > OK, going this way, there is precedence for a MOZILLA_PORT variable > > (cf APACHE_PORT, GHOSTSCRIPT_PORT) for choosing one of a number of > > equivalent choices. > > I look at converting over to a MOZILLA_PORT, but WITH_MOZILLA predates > those other options, and people have grown accustom to it. Hmm, oh well. Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFASYzSWry0BWjoQKURAppxAJ4jBU4QGCgIV2byO3gEEORmre10KgCgtKle fN9itdRmMMNgnd4r3Rgp50Q= =RUet -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040306083322.GA28004>