Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 14 Jan 2024 21:53:54 GMT
From:      Arthur Kiyanovski <akiyano@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 9d773b0d5f56 - stable/14 - ena: Remove CQ tail pointer update API
Message-ID:  <202401142153.40ELrsLN041577@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by akiyano:

URL: https://cgit.FreeBSD.org/src/commit/?id=9d773b0d5f56268ce7fc2fc60d8d551963de8f36

commit 9d773b0d5f56268ce7fc2fc60d8d551963de8f36
Author:     Osama Abboud <osamaabb@amazon.com>
AuthorDate: 2023-09-11 08:43:08 +0000
Commit:     Arthur Kiyanovski <akiyano@FreeBSD.org>
CommitDate: 2024-01-14 21:18:10 +0000

    ena: Remove CQ tail pointer update API
    
    This commit removes the usage of this API from the freebsd driver since
    the relevant functionality is not supported by the device.
    
    Approved by: cperciva (mentor)
    MFC after: 2 weeks
    Sponsored by: Amazon, Inc.
    
    (cherry picked from commit 2835752e075f2fa3edcb596df8306c570ec4cae6)
---
 sys/dev/ena/ena_datapath.c | 3 ---
 sys/dev/ena/ena_netmap.c   | 1 -
 2 files changed, 4 deletions(-)

diff --git a/sys/dev/ena/ena_datapath.c b/sys/dev/ena/ena_datapath.c
index e5c424139d3c..177f33ea8ef3 100644
--- a/sys/dev/ena/ena_datapath.c
+++ b/sys/dev/ena/ena_datapath.c
@@ -298,7 +298,6 @@ ena_tx_cleanup(struct ena_ring *tx_ring)
 			ena_com_comp_ack(
 			    &adapter->ena_dev->io_sq_queues[ena_qid],
 			    total_done);
-			ena_com_update_dev_comp_head(io_cq);
 			total_done = 0;
 		}
 	} while (likely(--budget));
@@ -313,7 +312,6 @@ ena_tx_cleanup(struct ena_ring *tx_ring)
 		tx_ring->next_to_clean = next_to_clean;
 		ena_com_comp_ack(&adapter->ena_dev->io_sq_queues[ena_qid],
 		    total_done);
-		ena_com_update_dev_comp_head(io_cq);
 	}
 
 	/*
@@ -690,7 +688,6 @@ ena_rx_cleanup(struct ena_ring *rx_ring)
 	    ENA_RX_REFILL_THRESH_PACKET);
 
 	if (refill_required > refill_threshold) {
-		ena_com_update_dev_comp_head(rx_ring->ena_com_io_cq);
 		ena_refill_rx_bufs(rx_ring, refill_required);
 	}
 
diff --git a/sys/dev/ena/ena_netmap.c b/sys/dev/ena/ena_netmap.c
index 9ef0619829f4..a8d7cad05ab5 100644
--- a/sys/dev/ena/ena_netmap.c
+++ b/sys/dev/ena/ena_netmap.c
@@ -814,7 +814,6 @@ ena_netmap_tx_cleanup(struct ena_netmap_ctx *ctx)
 		/* acknowledge completion of sent packets */
 		ctx->ring->next_to_clean = ctx->nt;
 		ena_com_comp_ack(ctx->ring->ena_com_io_sq, total_tx_descs);
-		ena_com_update_dev_comp_head(ctx->ring->ena_com_io_cq);
 	}
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202401142153.40ELrsLN041577>