Date: Sun, 29 Dec 2002 22:23:38 -0800 From: David Schultz <dschultz@uclink.Berkeley.EDU> To: Juli Mallett <jmallett@FreeBSD.ORG> Cc: Craig Rodrigues <rodrigc@attbi.com>, current@FreeBSD.ORG, sparc64@FreeBSD.ORG Subject: Re: sparc64 tinderbox failure Message-ID: <20021230062338.GB5984@HAL9000.homeunix.com> In-Reply-To: <20021229215647.A79512@FreeBSD.org> References: <200212300321.gBU3LMWB011861@bowie.private> <20021229202731.B22633@citusc.usc.edu> <20021230051705.GA5307@HAL9000.homeunix.com> <20021230053810.GA79308@attbi.com> <20021229215647.A79512@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake Juli Mallett <jmallett@FreeBSD.ORG>: > * De: Craig Rodrigues <rodrigc@attbi.com> [ Data: 2002-12-29 ] > [ Subjecte: Re: sparc64 tinderbox failure ] > > I'm not sure if your patch will solve the problem. > > The offending code is here: > > 240 if (lflag) { > > 241 char buf[32]; > > 242 snprintf(buf, sizeof(buf), "%ld-blocks", blocksize); > > 243 printf("%-13s %*s %*s\n", > > 244 "Device:", > > 245 hlen, buf, > > 246 hlen, "Used:"); > > 247 } > > > > > > Doesn't the printf() statement in question have the wrong number of > > arguments? > > No, it's using variable field-length specifiers. Right. The complaint is that hlen is 64 bits and the printf() expects the field length specifier to be an int. The same goes for getbsize(&hlen, ...), so I'm not sure why the compiler didn't complain about a type mismatch. I guess it just coerced the pointer to an int *. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-sparc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021230062338.GB5984>