Date: Thu, 18 Jun 2009 23:02:42 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org, Dmitry Morozovsky <marck@rinet.ru> Subject: Re: svn commit: r194377 - stable/7/sys/dev/ath/ath_hal Message-ID: <86eith5k7h.fsf@ds4.des.no> In-Reply-To: <200906181455.26797.jhb@freebsd.org> (John Baldwin's message of "Thu, 18 Jun 2009 14:55:26 -0400") References: <200906171731.n5HHVktG082752@svn.freebsd.org> <alpine.BSF.2.00.0906181414270.40949@woozle.rinet.ru> <86iqit5sms.fsf@ds4.des.no> <200906181455.26797.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin <jhb@freebsd.org> writes: > I think Dmitry means more that all the prop changes stuff clutters the ac= tual=20 > commit messages. I would like to see them removed from the subject line = at=20 > least so that the subject line clearly shows where real changes are being= =20 > made. That's reasonable - but I would still very much like to see prop changes in the commit email. It's not just svn:mergeinfo, there have also been cases of incorrect svn:keywords, and even someone who set svn:mime-type to application/octet-stream on a couple of files because they couldn't figure out the correct svn:keywords syntax. BTW, if you do as Dmitry suggests, how will you handle props-only commits like r192599, r192646 or r192653? DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86eith5k7h.fsf>