Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Jun 2002 16:41:50 +0200
From:      Rolandas Naujikas <rolnas@takas.lt>
To:        Jens Rehsack <rehsack@liwing.de>, dwcjr@FreeBSD.org
Cc:        ports@FreeBSD.org
Subject:   ports/net/{samba,samba-tng} doesn't batch {fetch,checksum} cleanly
Message-ID:  <20020603144150.GA83798@rolnas>

next in thread | raw e-mail | index | archive | help
--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline


After last commit, the situation is:
----------------------------------------------------------------
[rolnas@rolnas /usr/ports/net/samba]$ make -DBATCH fetch
/usr/ports/net/samba/scripts/configure.samba: cannot create
/usr/tmp/usr/ports/net/samba/Makefile.inc: directory nonexistent
*** Error code 2

Stop in /usr/ports/net/samba.
----------------------------------------------------------------

The solution possible is to look in www/mod_php4/scripts/configure.php to
put ${MKDIR} ${WRKDIRPREFIX}${REALCURDIR} before creating
${WRKDIRPREFIX}${REALCURDIR}/Makefile.inc

The other problem is checklist.* files left around with -DBATCH (same
problem in www/mod_php4/scripts/configure.php). The solution to do not use
temporary file to read selected options and use backtips.

The patch are below.
 
Rolandas

--ReaqsoxgOBHFXBhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch-configure

--- configure.samba.orig	Wed May 29 15:21:11 2002
+++ configure.samba	Wed May 29 17:04:31 2002
@@ -4,14 +4,12 @@
 	exit
 fi
 
-tempfile=`/usr/bin/mktemp -t checklist`
-
 if [ "${BATCH}" ]; then
 	if [ "${SAMBA_OPTIONS}" ]; then
 		set ${SAMBA_OPTIONS}
 	fi
 else
-	/usr/bin/dialog --title "configuration options" --clear \
+	options=`/usr/bin/dialog --title "configuration options" --clear \
 		--checklist "\n\
 Please select desired options:" -1 -1 9 \
 syslog		"With syslog support" OFF \
@@ -22,14 +20,13 @@
 utmp		"With UTMP support" OFF \
 msdfs		"With MSDFS support" OFF \
 quota		"With Quota support" OFF \
-2> $tempfile
+2>&1 1>/dev/tty`
 
 	retval=$?
 
-	if [ -s $tempfile ]; then
-		set `cat $tempfile`
+	if [ -n "$options" ]; then
+		set $options
 	fi
-	rm -f $tempfile
 
 	case $retval in
 		0)	if [ -z "$*" ]; then
@@ -42,6 +39,7 @@
 	esac
 fi
 
+${MKDIR} ${WRKDIRPREFIX}${REALCURDIR}
 echo "SCRIPT_RUN=yes" >${WRKDIRPREFIX}${REALCURDIR}/Makefile.inc
 
 while [ "$1" ]; do

--ReaqsoxgOBHFXBhH--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020603144150.GA83798>