Date: Sun, 13 Jun 2004 18:23:22 -0700 (PDT) From: Doug White <dwhite@gumbysoft.com> To: current@freebsd.org Subject: very rough if_sk fixes Message-ID: <20040613181820.H84464@carver.gumbysoft.com>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-622445270-1087176202=:84464 Content-Type: TEXT/PLAIN; charset=US-ASCII Hey all, I ran out and bought a Linksys EG1032 today and fixed up some of the witness warnings and a detach panic. I'm not 100% sure my lock relocation is totally correct, though, so if someone wants to look at this and tell me I have no idea what I'm doing, that'd be great. :-) Suggestions appreciated. In particular I may need to tighten up the locking and ordering in skc_detach() since I'm not sure if we can take an interrupt in that context, and it'd be kinda bad to. Most of the changes were trivial... too trivial maybe :-) I'm also hoarding a copy of this patch at http://people.freebsd.org/~dwhite/if_sk.c.diff if the attachment doesn't come through. Thanks! -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org --0-622445270-1087176202=:84464 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="if_sk.c.diff" Content-Transfer-Encoding: BASE64 Content-ID: <20040613182322.K84464@carver.gumbysoft.com> Content-Description: Content-Disposition: attachment; filename="if_sk.c.diff" LS0tIGlmX3NrLmMub3JpZwlTdW4gSnVuIDEzIDE2OjUwOjE1IDIwMDQNCisr KyBpZl9zay5jCVN1biBKdW4gMTMgMTg6MTE6MTYgMjAwNA0KQEAgLTE0NDYs MTEgKzE0NDYsMjIgQEANCiANCiAJY2FsbG91dF9oYW5kbGVfaW5pdCgmc2Nf aWYtPnNrX3RpY2tfY2gpOw0KIA0KKwkvKiBYWFggZHdoaXRlDQorCSAqIERy b3AgaW50ZXJmYWNlIGxvY2sgYXJvdW5kIGV0aGVyX2lmYXR0YWNoLCB3aGlj aA0KKwkgKiBjYW5ub3QgYmUgY2FsbGVkIHdpdGggbG9ja3MgaGVsZC4NCisJ ICovDQorCVNLX1VOTE9DSyhzYyk7DQorDQogCS8qDQogCSAqIENhbGwgTUkg YXR0YWNoIHJvdXRpbmUuDQogCSAqLw0KIAlldGhlcl9pZmF0dGFjaChpZnAs IHNjX2lmLT5hcnBjb20uYWNfZW5hZGRyKTsNCiANCisJLyogWFhYIGR3aGl0 ZQ0KKwkgKiBQaWNrIHRoZSBsb2NrIGJhY2sgdXAuDQorCSAqLw0KKwlTS19M T0NLKHNjKTsNCisNCiAJLyoNCiAJICogRG8gbWlpYnVzIHNldHVwLg0KIAkg Ki8NCkBAIC0xNjQ3LDcgKzE2NTgsNyBAQA0KIAlidXNfZ2VuZXJpY19hdHRh Y2goZGV2KTsNCiANCiAJLyogSG9vayBpbnRlcnJ1cHQgbGFzdCB0byBhdm9p ZCBoYXZpbmcgdG8gbG9jayBzb2Z0YyAqLw0KLQllcnJvciA9IGJ1c19zZXR1 cF9pbnRyKGRldiwgc2MtPnNrX2lycSwgSU5UUl9UWVBFX05FVCwNCisJZXJy b3IgPSBidXNfc2V0dXBfaW50cihkZXYsIHNjLT5za19pcnEsIElOVFJfVFlQ RV9ORVR8SU5UUl9NUFNBRkUsDQogCSAgICBza19pbnRyLCBzYywgJnNjLT5z a19pbnRyaGFuZCk7DQogDQogCWlmIChlcnJvcikgew0KQEAgLTE2ODUsMTAg KzE2OTYsMjIgQEANCiAJLyogVGhlc2Ugc2hvdWxkIG9ubHkgYmUgYWN0aXZl IGlmIGF0dGFjaF94bWFjIHN1Y2NlZWRlZCAqLw0KIAlpZiAoZGV2aWNlX2lz X2F0dGFjaGVkKGRldikpIHsNCiAJCXNrX3N0b3Aoc2NfaWYpOw0KKwkJLyog WFhYIGR3aGl0ZQ0KKwkJICogQ2FuJ3QgaG9sZCBsb2NrcyB3aGlsZSBjYWxs aW5nIGRldGFjaCANCisJCSAqLw0KKwkJU0tfSUZfVU5MT0NLKHNjX2lmKTsN CiAJCWV0aGVyX2lmZGV0YWNoKGlmcCk7DQorCQlTS19JRl9MT0NLKHNjX2lm KTsNCiAJfQ0KKwkvKiBYWFggZHdoaXRlDQorCSAqIFdlJ3JlIGdlbmVyYWxs eSBjYWxsZWQgZnJvbSBza2NfZGV0YWNoKCkgd2hpY2ggaXMgdXNpbmcNCisJ ICogZGV2aWNlX2RlbGV0ZV9jaGlsZCgpIHRvIGdldCB0byBoZXJlLiBJdCdz IGFscmVhZHkgdHJhc2hlZA0KKwkgKiBtaWlidXMgZm9yIHVzLCBzbyBkb24n dCBkbyBpdCBoZXJlIG9yIHdlJ2xsIHBhbmljLg0KKwkgKi8NCisJLyoNCiAJ aWYgKHNjX2lmLT5za19taWlidXMpDQogCQlkZXZpY2VfZGVsZXRlX2NoaWxk KGRldiwgc2NfaWYtPnNrX21paWJ1cyk7DQorCSovDQogCWJ1c19nZW5lcmlj X2RldGFjaChkZXYpOw0KIAlpZiAoc2NfaWYtPnNrX2NkYXRhLnNrX2p1bWJv X2J1ZikNCiAJCWNvbnRpZ2ZyZWUoc2NfaWYtPnNrX2NkYXRhLnNrX2p1bWJv X2J1ZiwgU0tfSk1FTSwgTV9ERVZCVUYpOw0KQEAgLTE3MDksNyArMTczMiwx MiBAQA0KIA0KIAlzYyA9IGRldmljZV9nZXRfc29mdGMoZGV2KTsNCiAJS0FT U0VSVChtdHhfaW5pdGlhbGl6ZWQoJnNjLT5za19tdHgpLCAoInNrIG11dGV4 IG5vdCBpbml0aWFsaXplZCIpKTsNCisJLyogWFhYIGR3aGl0ZQ0KKwkgKiBE b24ndCBuZWVkIHRoZSBsb2NrcyBoZXJlPw0KKwkgKi8NCisJLyoNCiAJU0tf TE9DSyhzYyk7DQorCSovDQogDQogCWlmIChkZXZpY2VfaXNfYWxpdmUoZGV2 KSkgew0KIAkJaWYgKHNjLT5za19kZXZzW1NLX1BPUlRfQV0gIT0gTlVMTCkN CkBAIC0xNzI2LDcgKzE3NTQsMTIgQEANCiAJaWYgKHNjLT5za19yZXMpDQog CQlidXNfcmVsZWFzZV9yZXNvdXJjZShkZXYsIFNLX1JFUywgU0tfUklELCBz Yy0+c2tfcmVzKTsNCiANCisJLyogWFhYIGR3aGl0ZQ0KKwkgKiBEb24ndCBu ZWVkIHRoaXM/DQorCSAqLw0KKwkvKg0KIAlTS19VTkxPQ0soc2MpOw0KKwkq Lw0KIAltdHhfZGVzdHJveSgmc2MtPnNrX210eCk7DQogDQogCXJldHVybigw KTsNCg== --0-622445270-1087176202=:84464--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040613181820.H84464>