Date: Mon, 29 Jul 2013 07:15:28 GMT From: Thomas Schweikle <tps@vr-web.de> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/180920: open-vm-tools-nox11 does not compile because of unsigned signed compares Message-ID: <201307290715.r6T7FS8H083814@oldred.freebsd.org> Resent-Message-ID: <201307290720.r6T7K007008407@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 180920
>Category: misc
>Synopsis: open-vm-tools-nox11 does not compile because of unsigned signed compares
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Jul 29 07:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Thomas Schweikle
>Release: FreeBSD 10.0-CURRENT
>Organization:
n.a.
>Environment:
FreeBSD test-tps-fbsdc-muc.bfs.de 10.0-CURRENT FreeBSD 10.0-CURRENT #10: Fri Jul 26 18:22:07 CEST 2013 root@test-tps-fbsdc-muc.bfs.de:/usr/obj/usr/src/sys/TEST-TPS-FBSDC-MUC amd64
>Description:
hgfsServer.c:3560:19: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
if (pathLength < 0 || pathLength >= sizeof p.mountPoint) {
~~~~~~~~~~ ^ ~
hgfsServer.c:4559:30: error: comparison of constant 255 with expression of type 'HgfsOp' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
if (HGFS_V4_LEGACY_OPCODE == request->op) {
~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
2 errors generated.
*** Error code 1
Stop.
make: stopped in /usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-8.6.0-425873/lib/hgfsServer
*** Error code 1
Stop.
make: stopped in /usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-8.6.0-425873/lib
*** Error code 1
Stop.
make: stopped in /usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-8.6.0-425873
*** Error code 1
Stop.
make: stopped in /usr/ports/emulators/open-vm-tools-nox11
>How-To-Repeat:
On all active FreeBSD versions (8,9, CURRENT): go to /usr/ports/emulators/open-vm-tools-nox11, then execute "make clean build". Build step will fail due to the above compiler error.
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307290715.r6T7FS8H083814>