Date: Wed, 4 Jul 2007 18:42:49 +0400 From: Andrey Chernov <ache@nagual.pp.ru> To: Sean Farley <scf@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/df df.c src/bin/sh var.c src/include stdlib.h src/libexec/pppoed pppoed.c src/sys/sys param.h src/lib/libc/stdlib Makefile.inc getenv.3 getenv.c putenv.c setenv.c src/tools/regression/environ Makefile Makefile.envctl ... Message-ID: <20070704144249.GB31254@nagual.pp.ru> In-Reply-To: <200707040000.l6400gLs044775@repoman.freebsd.org> References: <200707040000.l6400gLs044775@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 04, 2007 at 12:00:41AM +0000, Sean Farley wrote: > Several patches to base utilities to handle the POSIX changes from > Andrey Chernov's previous commit. A few I re-wrote to use setenv() > instead of putenv(). Replacing putenv() with setenv() should care about the case when putenv() uses getenv()-provided value directly, like in sh's var.c. It should be copied by strdup() or something like first to not break env before following setenv() call. In my patch I always care about this. -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070704144249.GB31254>