Date: Tue, 03 Feb 1998 20:31:33 +0200 From: Mark Murray <mark@grondar.za> To: Luigi Rizzo <luigi@labinfo.iet.unipi.it> Cc: multimedia@FreeBSD.ORG, hasty@rah.star-gate.com Subject: Re: bt848 feedback... Message-ID: <199802031831.UAA25042@greenpeace.grondar.za>
next in thread | raw e-mail | index | archive | help
Luigi Rizzo wrote: > In the latest release of the Bt848 code, I noticed the BT848_I2CWR > ioctl that I submitted some time ago has been put in video_ioctl(), > but it really belongs in tuner_ioctl() , where other I2C devices are > also accessed. Dammit. My fault. Sorry. > It's just a matter of moving the block in the other function (and > moving the variable declarations at the beginning of video_ioctl, > a hundred lines above... what was wrong with declaring variables > within the block they are used, as in the patch I submitted!). Please try to keep your coding style consistent with the existing code. There is nothing technically wrong with having the variables in the place you put them; however > > Oh btw the code works perfectly on 2.2.1 > > cheers > luigi > -----------------------------+-------------------------------------- > Luigi Rizzo | Dip. di Ingegneria dell'Informazione > email: luigi@iet.unipi.it | Universita' di Pisa > tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) > fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ > _____________________________|______________________________________ -- Mark Murray Join the anti-SPAM movement: http://www.cauce.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802031831.UAA25042>