Date: Tue, 13 Sep 2016 09:15:33 +0000 From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 212176] x11/xfce4-taskmanager segfault Message-ID: <bug-212176-28711-UAVM9oWKXz@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-212176-28711@https.bugs.freebsd.org/bugzilla/> References: <bug-212176-28711@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212176 --- Comment #6 from Ivan <bsd@abinet.ru> --- Created attachment 174716 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D174716&action= =3Dedit patch Problem is here g_strlcpy (text, p, g_utf8_strlen (text, -1)); To utf-8 unaware function number of chars are passed instead of bytes, so i= t's possible for 2 bytes chars it will split in half leading to incorrect unico= de sequence. Attached patch resolves the issue, however crash still can occur if p >=3D = text, however as p is substring of text, the situation is expected to never happe= n in normal conditions. I found no safe analog in gtk functions for strlcpy, only strncpy which is = not considered safe. The alternative is switch to icu, however this is another story. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-212176-28711-UAVM9oWKXz>